Added Ruby 3 fix for unique_utils #532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWayfer
approved these changes
Aug 23, 2023
AlexWayfer
requested changes
Aug 23, 2023
There was a problem hiding this comment.
I agree with proposed changes, but it breaks Ruby 2.5 and 2.6.
I suggest to drop their support: they're not supported officially even for security.
The second way is to use ruby2_keywords: https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/#a-compatible-delegation
But I don't like that much.
|
I just drop under ruby 2.7. |
|
@simonhildebrandt rebase to the updated |
marocchino
reviewed
Aug 23, 2023
|
It would be very helpful if you also update the |
AlexWayfer
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During our Ruby 3 upgrade I noticed an argument error while doing this:
... turns out
FFaker::UniqueUtils#method_missingdoesn't handle keyword args the Ruby 3 way. This change (with test) fixes that.