Updated support for QZFM_UCL data #2130 #2242
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fieldtrip#2130 - So we are now thinking of including HelmetManufacturer and HelmetManufacturersModelName in the json file. The latter would contain a text field with something like: 'slotnumber-56_location-wholehead_fit-custom' - I have used the grad.type = 'QZFM_UCL' to differentiate ourselves from other facilities using QZFM sensors All seems to work fine with existing test data. Issue: I can't seem to get ft_channelselection working without providing a third input argument (i.e. it's not picking up the senstype automatically for some reason)
|
Hey any updates on this @robertoostenveld? |
|
Hi @neurofractal Rob, sorry for having dropped this for so long. I think that the PR is still relevant, no? Would you still be willing to work on this a bit? If so, that would be great, perhaps we can get things on track again. Would you mind first to resolve the current conflict, and that we take it from there? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2130
So we are n 8000 ow thinking of including HelmetManufacturer and HelmetManufacturersModelName in the json file. The latter would contain a text field with something like: 'slotnumber-56_location-wholehead_fit-custom'
I have used the grad.type = 'QZFM_UCL' to differentiate ourselves from other facilities using QZFM sensors
All seems to work fine with existing test data.