Update wsdl:part messages to use XML name from referenced element #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 8, 2018 16:01
With the current encoder, a WSDL message such as
<wsdl:message name="IELDSubmissionService_Submit_InputMessage">
<wsdl:part name="parameters" element="tns:Submit"/>
</wsdl:message>
Will have the XML tag of "parameters" rather than "Submit". In other
words, the current generated output looks like:
type OperationIELDSubmissionService_Submit_InputMessage struct {
Parameters *Submit `xml:"parameters,omitempty" json:"parameters,omitempty" yaml:"parameters,omitempty"`
}
The correct output should be:
type OperationIELDSubmissionService_Submit_InputMessage struct {
Submit *Submit `xml:"Submit,omitempty" json:"Submit,omitempty" yaml:"Submit,omitempty"`
}
070b428 to
424e6ef
Compare
|
I don't particularly like the generated code's variable names reflecting their type, but it works. Merging. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings! First of all, thanks for an awesome Go package!
I am interfacing with a WSDL-based SOAP service that worked with an older version of your
wsdl2golibrary. When I upgraded from8f16131toc0bfd34, our client started generating an XML request that the server now rejects. The reason for this is due to<wsdl:part>messages using thepartname attribute instead of the referencedelement's name.Here is the relevant
<wsdl:part>message snippet from our WSDL file:The current wsdl2go master XML output (rejected by server):
<parameters><data><ELDIdentifier>...</parameters>.The older wsdl2go output (accepted by server):
<Submit xmlns="http://www.fmcsa.dot.gov/schemas/FMCSA.ELD.Infrastructure"><data><ELDIdentifier>...</Submit>In other words, the XML tag is now
parametersinstead ofSubmitfor the above WSDL snippet:I took a shot at a PR that fixes my particular use case, but I don't know enough about SOAP to know what the proper behavior for all
<wsdl:part>tags should be.