8000 GitHub - filmakarov/safe-test-module
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

filmakarov/safe-test-module

Folders and files

NameName
Last commit message
Last commit date

Latest commit

 

History

10 Commits
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 

Repository files navigation

Safe Test Module

Test Module - A test module that allows accounts that are not related to the Safe to withdraw a predetermined amount of a specific token using EIP-712 signature issued by the Safe owner.

Safety considerations

This design is unsafe! In the "Solidity Challenge" document I received via email it is stated, that "Now they can generate a signature which allows ANYONE to withdraw Unicorn tokens from their Safe."

To allow ANYONE use the signature, there should be no spender address in the Allowance. With this design the signature can be picked up from mempool and the transaction can be frontrunned.

Better way to implement this module would be with specifiyng the spender for each Allowance, so the allowance can only be used by a spender specified by a Safe owner when signing the data hash. Thus frontrunning will not be an issue.

About

No description, website, or topics provided.

Resources

Stars

Watchers

Forks

Releases

No releases published

Packages

No packages published
0