8000 Proposal for public folders by alexandrestein · Pull Request #798 · filebrowser/filebrowser · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Proposal for public folders #798 8000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Proposal for public folders #798

wants to merge 3 commits into from

Conversation

alexandrestein
Copy link
Contributor

Description
I try to make it easy to share folders.
I think folder should be taken as is and not as a big zip.
My goal is to use the Listing component which I feed with a GET request to /api/public/resources/.

I don't see how you fill-up the Listing component.
So at this point this is not a working solution.
I have the folder content from the server but I'm not able to show it.

I would be happy to have some help from you on the Vue side.
To fill-up the component and be able to explore it from the public area using the hash.

What do you think?

@ttys3
Copy link
Contributor
ttys3 commented Jul 2, 2019

good job!
by the way, I think we'd better use Preview when double click on a single file.

@alexandrestein
Copy link
Contributor Author

You would like to use the Preview component instead of the actual link <a> in Share.vue, I'm right?

I think this would be great, but in an other PR or after this one works.
For now I just want to give access to directories without the need of downloading the all tree of the folder.

Does some one can tell me how to fill-up listing component?
Or you can update the code to make it works. 😄

@ttys3
Copy link
Contributor
ttys3 commented Jul 3, 2019 •
edited
Loading

@alexandrestein yes.
we need add some computed method like:
isDir
isFile

when it is a dir, we let the Listing component to render
and if it is a single file, , we let the Preview component to render

<template>
  <div class="share" v-if="loaded">
        <listing v-if="isDir" ></listing>
	<preview v-if="isFile" ></preview>
  </div
</template>

since the original Preview.vue depends on some state , we probably can not use the Preview directly, this may need some tricks

@alexandrestein
Copy link
Contributor Author

Thank you @ttys3 but it's not my actual concern.
The preview can be great but display folder is what I want right now.

I was hoping that maintainers or some one who knows the package well enough could finish this "partly" done stuff.

I'm sure there is not too much to do to make it works.

@hacdias
Copy link
Member
hacdias commented Jan 9, 2020

I'm closing this since this repository will be archived. Please read #532 for more information. Thanks for all your contributions!

@hacdias hacdias closed this Jan 9, 2020
@snyk-bot snyk-bot mentioned this pull request Mar 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexandrestein @ttys3 @hacdias
0