8000 feat: add env-var to disable F3 activation by rjan90 · Pull Request #12920 · filecoin-project/lotus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add env-var to disable F3 activation #12920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 3, 2025
Merged

feat: add env-var to disable F3 activation #12920

merged 6 commits into from
Mar 3, 2025

Conversation

rjan90
Copy link
Contributor
@rjan90 rjan90 commented Feb 25, 2025 •
edited
Loading

Related Issues

filecoin-project/go-f3#732

Proposed Changes

Adds a new environment variable LOTUS_DISABLE_F3_ACTIVATION that allows disabling F3 activation for a specific contract address or epoch.

Format: contract:address or epoch:number

Checklist

Before you mark the PR ready for review, please make sure that:

@rjan90 rjan90 marked this pull request as ready for review February 25, 2025 11:11
@rjan90 rjan90 requested a review from Kubuxu February 25, 2025 11:11
@Kubuxu
Copy link
Contributor
Kubuxu commented Feb 25, 2025

The checks should be applied in NewManifestProvider and totally disable the manifest providers. So the contract disable would disable the contract manifest provider, and epoch would disable the static manifest provider.

@rjan90
feat: add env-var to disable F3 activation
0b2d90f 
Adds a new environment variable LOTUS_DISABLE_F3_ACTIVATION that allows
disabling F3 activation for specific contract addresses or epochs.

Format: contract:address or epoch:number
@rjan90
chore: add changelog entry
7936f1d 
chore: add changelog entry
@rjan90
Copy link
Contributor Author
rjan90 commented Feb 25, 2025

Thanks! I have removed the the check in fetchManifest, and added the check to NewManifestProvider and:

  • Completely disable the contract manifest provider if the contract address matches
  • Completely disables the static manifest provider if the bootstrap epoch matches

@rjan90
Copy link
Contributor Author
rjan90 commented Feb 26, 2025

@Kubuxu Wondering if it is worth changing the LOTUS_DISABLE_F3 environment variable here, so it is a clearer distinction between all of them?

  • LOTUS_DISABLE_F3_PASSIVE_TESTING = disables passive testing
  • LOTUS_DISABLE_F3_ACTIVATION = disable the F3 activation, either by contract or epoch
  • Rename LOTUS_DISABLE_F3 --> LOTUS_DISABLE_F3_ACTIVE_NETWORK = disables a already active/running F3 network.

@rjan90
chore: rename LOTUS_DISABLE_F3 to LOTUS_DISABLE_F3_SUBSYSTEM
ebc04b8 
chore: rename LOTUS_DISABLE_F3 to LOTUS_DISABLE_F3_SUBSYSTEM
@rjan90
Copy link
Contributor Author
rjan90 commented Feb 27, 2025

Updated LOTUS_DISABLE_F3 to LOTUS_DISABLE_F3_SUBSYSTEM to provide a clearer description of its function, aligning it with the naming conventions of the other F3-environment variables: ebc04b8

@BigLep BigLep moved this from In progress to In review in F3 Feb 28, 2025
@rjan90 rjan90 mentioned this pull request Feb 28, 2025
Closed
rjan90 and others added 2 commits March 3, 2025 08:32
@rjan90
Merge branch 'master' into phi/F3-env-var
aa1a055
@Kubuxu
Clenaup the code
35cb233 
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
@Kubuxu
Copy link
Contributor
Kubuxu commented Mar 3, 2025

@rjan90 take a look

Kubuxu
Kubuxu approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor
@Kubuxu Kubuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but I made some changes

8000 @github-project-automation github-project-automation bot moved this from ⌨️ In Progress to ✔️ Approved by reviewer in FilOz Mar 3, 2025
@rjan90
chore: address lint-error
8a09991 
chore: address lint-error
@rjan90
Copy link
Contributor Author
rjan90 commented Mar 3, 2025

Fixed the failing lint-check in: 8a09991

@rjan90 rjan90 merged commit 05318a5 into master Mar 3, 2025
89 checks passed
@rjan90 rjan90 deleted the phi/F3-env-var branch March 3, 2025 17:47
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Mar 3, 2025
@github-project-automation github-project-automation bot moved this from In review to Done in F3 Mar 3, 2025
@rjan90 rjan90 mentioned this pull request Mar 3, 2025
Closed
@rjan90 rjan90 moved this from 🎉 Done to ☑️ Done (Archive) in FilOz Mar 18, 2025
@rjan90 rjan90 mentioned this pull request Mar 19, 2025
Merged
8 tasks
@simlecode simlecode mentioned this pull request Apr 14, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kubuxu Kubuxu Kubuxu approved these changes

Assignees

@rjan90 rjan90

Labels
None yet
Projects
F3
Status: Done
FilOz
Status: ☑️ Done (Archive)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjan90 @Kubuxu
0