fix cron not deleting transfers of the same day #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not really sure what this does, but my assumption is that this changes the behaviour of FileSender to interpret the expire date as «unavailable from» instead of «unavailable after» Does this sound reasonable? |
|
The problem is the application has 2 behaviours for checking if a transfer is expired :
I'm not sure if it's understandable. |
|
Is this still an issue, if so I will schedule a look see and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have users who can see transfers on "Currently available transfers" panel even if the transfer expired on the same day.
The cause is related to the EXPIRED request called by the cron which doesn't include the same day.