removed blitting support #810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e0d192d to
d6c7c7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dubious feature which was off by default did not contribute anything to performance (on Chrome at least) and complicated the code.
Removed
grid.properties.useBitBlit,grid.canvas.bc,grid.canvas.buffer; thegrid.canvas.flushBuffer()method is now a no-op.Not sure why the original author thought this would help. Normally used to composite smaller bitmpas into a larger bitmap so those portions don't have to redraw the entire view on every frame. This is not the case with Hypergrid where we are redrawing the entire grid on every frame. The other concept of prepping an off-stage view while the user is looking at the current frame is not an advantage if the entire frame can be drawn during blanking. There is no parallel processing in JS especially when GPU is bottleneck. Maybe I don't get it; maybe we can make this work for us. If so we can always put it back in.