[WIP] Expand broadcast, raise*, and open methods to include metadata #1595
+2,629
−2,349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for fdc3 failed. Why did it fail? →
|
16 tasks
robmoffat
reviewed
May 22, 2025
| @@ -18,3 +18,15 @@ export interface ContextMetadata { | |||
| */ | |||
| readonly source: AppIdentifier; | |||
| } | |||
|
|
|||
| export interface AppProvidableContextMetadata { | |||
| signature?: string; | |||
There was a problem hiding this comment.
why are apps limited on the metadata they can send? Shouldn't they be allowed to put anything in here?
There was a problem hiding this comment.
The discussions around #1290 indicated that we should limit the metadata. Let's discuss this at the next Web meeting.
| }) | ||
| ``` | ||
|
|
||
| ### Timestamp |
There was a problem hiding this comment.
do we need this? We already have a timestamp in the message meta I think
There was a problem hiding this comment.
It was in my notes as one of the few properties we should support. Let's discuss what metadata properties should be included at the next Web meeting.
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change
Adds the
metadataproperty at the end of the.broadcast(),.raiseIntent(),.raiseIntentForContext(), and.open()methods.Includes schema updates, doc updates, and implementation updates.
Provides placeholder space for
signature(see #1571) andhostParams(#1546).Related Issue
Resolves #1290
Contributor License Agreement
Review Checklist
DesktopAgent,Channel,PrivateChannel,Listener,Bridging)?JSDoc comments on interfaces and types should be matched to the main documentation in /docs
Conformance test definitions should cover all required aspects of an FDC3 Desktop Agent implementation, which are usually marked with a MUST keyword, and optional features (SHOULD or MAY) where the format of those features is defined
The Web Connection protocol and Desktop Agent Communication Protocol schemas must be able to support all necessary aspects of the Desktop Agent API, while Bridging must support those aspects necessary for Desktop Agents to communicate with each other
npm run build) run and the results checked in?Generated code will be found at
/src/api/BrowserTypes.tsand/or/src/bridging/BridgingTypes.tsBaseContextschema applied viaallOf(as it is in existing types)?titleanddescriptionprovided for all properties defined in the schema?npm run build) run and the results checked in?Generated code will be found at
/src/context/ContextTypes.ts