Conformance 2.2: Adding A Channel Change Event Listener Doesn't Send addEventListenerRequest
#1606
Conversation
✅ Deploy Preview for fdc3 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Death currently incorporates a heck of a lot more than the change listed. Can you retarget this at the branch you used as a base so that we can practically implement a review please.
Also, don't forget that this event has to be sent regardless of registration to notify injected channel, select code and listeners in the proxy. Hence, please ensure that this change doesn't result in double transmission of the event nor double handling. It may not be obvious to a test that the event is double triggered, but it could have negative impact on application code. Hence, the test should check for the correct number of events is received IMHO. That should probably be standard on test involving events.
Good spot, done.
It actually isn't. The |
|
|
|
|
addEventListenerRequest
Describe your change
addEventListenerRequest#1605Contributor License Agreement
Review Checklist
DesktopAgent,Channel,PrivateChannel,Listener,Bridging)?JSDoc comments on interfaces and types should be matched to the main documentation in /docs
Conformance test definitions should cover all required aspects of an FDC3 Desktop Agent implementation, which are usually marked with a MUST keyword, and optional features (SHOULD or MAY) where the format of those features is defined
The Web Connection protocol and Desktop Agent Communication Protocol schemas must be able to support all necessary aspects of the Desktop Agent API, while Bridging must support those aspects necessary for Desktop Agents to communicate with each other
npm run build) run and the results checked in?Generated code will be found at
/src/api/BrowserTypes.tsand/or/src/bridging/BridgingTypes.tsBaseContextschema applied viaallOf(as it is in existing types)?titleanddescriptionprovided for all properties defined in the schema?npm run build) run and the results checked in?Generated code will be found at
/src/context/ContextTypes.ts