8000 Georgina Tarres Common Function QuantityDecreasedToZero - QuantityDecreasedToZero function Fix by regnosys-prod-user · Pull Request #3635 · finos/common-domain-model · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Georgina Tarres Common Function QuantityDecreasedToZero - QuantityDecreasedToZero function Fix #3635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 5.x.x
Choose a base branch
from
Open

Georgina Tarres Common Function QuantityDecreasedToZero - QuantityDecreasedToZero function Fix #3635

wants to merge 1 commit into from

Conversation

regnosys-prod-user
Copy link
Collaborator

No description provided.

@regnosys-prod-user regnosys-prod-user requested a review from a team as a code owner April 9, 2025 15:01
@regnosys-prod-user regnosys-prod-user added the Rosetta Pull requests which can be viewed in Rosetta label Apr 9, 2025
@regnosys-prod-user
Copy link
Collaborator Author

Common Function QuantityDecreasedToZero - QuantityDecreasedToZero function Fix

Background

The function QuantityDecreasedToZero incorrectly flags as a decrease cases where the quantity goes from zero to zero.

What is being released?

CDM Event Model - Decrease to zero

Background

The CDM function QuantityDecreasedToZero currently assumes that a decrease has occurred when the quantity is reduced to zero by checking that:

  1. The quantity in the after TradeState is zero.
  2. The quantity in the before TradeState is zero or greater.

This leads to incorrectly flagging as decrease cases where both the before and after quantities are zero, which should not be considered a decrease.

What is being released?

This contribution modifies the logic in the QuantityDecreasedToZero function so that a decrease is only considered when the before quantity is greater than zero, not equal to zero.

Review directions

In Rosetta, select the Textual View and search for the changes mentioned.

Review directions

Changes can be reviewed in PR: #3635

Note

This comment was generated via Rosetta.

@gtarres gtarres mentioned this pull request Apr 9, 2025
Open
@gtarres
Copy link
Contributor
gtarres commented Apr 9, 2025

This PR corresponds to ISSUE #3625

@CDM-ReleaseManagement-OT CDM-ReleaseManagement-OT linked an issue Apr 9, 2025 that may be closed by this pull request
Update in the QuantityDecreasedToZero to Correctly Handle Zero-to-Zero Quantity Changes #3625
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Rosetta Pull requests which can be viewed in Rosetta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update in the QuantityDecreasedToZero to Correctly Handle Zero-to-Zero Quantity Changes
2 participants
@regnosys-prod-user @gtarres
0