Oscar Twomey Resolving bug in Concentration Limit treatment - Resolving bug in Concentration Limit treatment #3690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…centration Limit treatment
Resolving bug in Concentration Limit treatment - Resolving bug in Concentration Limit treatmentBackground A bug was identified when adding concentration limits to a collateral treatment What is being released?
Review directions Changes can be reviewed in PR: #3690 Note This comment was generated via Rosetta. |
LionelSG-REGnosys
suggested changes
May 8, 2025
|
|
||
| type EligibleCollateralCriteria extends CollateralCriteriaBase: <"Represents a set of criteria used to specify eligible collateral."> | ||
| override collateralCriteria CollateralCriteria (1..1) |
There was a problem hiding this comment.
please add a comment to explain this line
There was a problem hiding this comment.
Please also prepare the release note
There was a problem hiding this comment.
@LionelSG-REGnosys updated
|
What is being released? Adding comment to overridden field. Note This comment was generated via Rosetta. |
LionelSG-REGnosys
approved these changes
May 9, 2025
|
superseded by #3698 |
llynhiavu
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.