10000 fix: Add Apache-2.0 license headers to source files by sam-holmes2 · Pull Request #1017 · finos/git-proxy · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Add Apache-2.0 license headers to source files #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Add Apache-2.0 license headers to source files #1017

wants to merge 2 commits into from

Conversation

sam-holmes2
8000 Copy link
@sam-holmes2 sam-holmes2 commented May 20, 2025 •
edited
Loading

Closes #1002
Also, ensured LICENSE file matches the Apache-2.0 license from https://www.apache.org/licenses/LICENSE-2.0

@netlify Netlify
Copy link
netlify bot commented May 20, 2025 •
edited
Loading

✅ Deploy Preview for endearing-brigadeiros-63f9d0 ready!

Name Link
🔨 Latest commit 52f0443
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/682df7796345830008a67880
😎 Deploy Preview https://deploy-preview-1017--endearing-brigadeiros-63f9d0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link
linux-foundation-easycla bot commented May 20, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@sam-holmes2 sam-holmes2 mentioned this pull request May 20, 2025
Open
2 tasks
@JamieSlome
Copy link
Member

@TheJuanAndOnly99 - can we get some guidance here as to where the Apache-2.0 headers should be? I assume on the src code only? And only on code that is entirely new and introduced by GitProxy contributors and maintainers?

@sam-holmes2 - i.e. any Material components should exclude Apache-2.0 headers or files that already have license attribution.

JamieSlome
JamieSlome reviewed May 20, 2025
View reviewed changes
.github/ISSUE_TEMPLATE/bug_report.md Outdated
@@ -1,3 +1,19 @@
<!--
Copyright 2020-2025 FINOS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheJuanAndOnly99 - can we confirm whether this should be FINOS or Citigroup?

@JamieSlome
Copy link
Member

@sam-holmes2 - can we also update the root LICENSE to remove the usage of Citigroup, and stick to the general template?

git-proxy/LICENSE

Line 189 in 9a3fd30

Copyright 2020 Citigroup

@JamieSlome JamieSlome added the documentation Improvements or additions to documentation label May 20, 2025
@JamieSlome JamieSlome linked an issue May 20, 2025 that may be closed by this pull request
Add Apache-2.0 license headers to source code #1002
Open
2 tasks
@maoo
Copy link
Member
maoo commented May 20, 2025

Hey @JamieSlome and @sam-holmes2 ! A couple of notes here:

  • I'd suggest to use the short version of the Apache 2.0 License header, which does not include copyright and helps managing the list of copyrights more efficiently
  • Files with data and documentation do not need to be covered by a license header, I'd suggest to focus on code.
  • Our default project blueprint, aligned with the standard project governance (which Git Proxy adheres to), expects copyrights to be listed in the LICENSE and in the NOTICE files.
  • The "copyright block" in LICENSE and NOTICE files should include the list of all contributors, and therefore NatWest, G-Research, Turntable (and maybe others) should be added to that list.

I hope this helps! Please let me know if you have any further question.

@sam-holmes2
updated license header to shorter version and applied to relevant cod…
0a882a4 
…e files (.js, .ts, .tsx, .jsx and .sh files) only. Also updated LICENSE and NOTICE files to contain list of contributors.
@sam-holmes2 sam-holmes2 force-pushed the fix/apache2-license-headers branch from 551ee24 to 0a882a4 Compare May 21, 2025 11:14
@sam-holmes2 sam-holmes2 changed the title Add Apache-2.0 license headers to source files fix: Add Apache-2.0 license headers to source files May 21, 2025
@github-actions github-actions bot added the fix label May 21, 2025
@sam-holmes2
Merge branch 'main' into fix/apache2-license-headers
52f0443 
Signed-off-by: Sam Holmes <49522843+sam-holmes2@users.noreply.github.com>
sam-holmes2
sam-holmes2 commented May 22, 2025
View reviewed changes
NOTICE
Copyright 2023 NatWest Group
Copyright 2023 Royal Bank of Canada
Copyright 2023 G-Research
Copyright 2023 Turntable
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JamieSlome Please could you double check this or let me know where I might find an up to date list

@sam-holmes2
Copy link
Author

Thanks for the review @maoo
If possible, please could you confirm where the requirement to list all contributors in the "copyright block" of the LICENSE and NOTICE files originates? Hoping to establish whether the responsibility sits with the contributors or maintainers to keep this list up to date.

Including relevant section of the FINOS CLA for reference:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamieSlome JamieSlome JamieSlome left review comments

@TheJuanAndOnly99 TheJuanAndOnly99 Awaiting requested review from TheJuanAndOnly99

Assignees

@sam-holmes2 sam-holmes2

Labels
documentation Improvements or additions to documentation fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Apache-2.0 license headers to source code
3 participants
@sam-holmes2 @JamieSlome @maoo
0