8000 fix: 946 associate commits by email by kriswest · Pull Request #973 · finos/git-proxy · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: 946 associate commits by email #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

fix: 946 associate commits by email #973

wants to merge 16 commits into from

Conversation

kriswest
8000
Copy link
Contributor

resolves #946

Updates push parsing to extract commiter emails and to associate commits with users via email, rather than the git user.name config.

Note that:

The Git username is not the same as your GitHub username.

https://docs.github.com/en/get-started/git-basics/setting-your-username-in-git

and

GitHub uses your commit email address to associate commits with your account on GitHub.

https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address

@netlify Netlify
Copy link
netlify bot commented Apr 11, 2025 •
edited
Loading

✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit d3832ca
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/682f003d79771f00083e3ba5

@kriswest kriswest changed the title 946 associate commits by email fix: 946 associate commits by email Apr 11, 2025
@kriswest
Copy link
Contributor Author

Looks like I didn't check the CLI test cases and need to sort something out there

@github-actions github-actions bot added the fix label Apr 11, 2025
@kriswest
Copy link
Contributor Author

Fixed the failing tests but am waiting on a review (in git proxy), will update monday

@codecov Codecov
Copy link
codecov bot commented Apr 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 69.69697% with 10 lines in your changes missing coverage. Please review.

Project coverage is 53.83%. Comparing base (fc6f166) to head (d3832ca).

Files with missing lines Patch % Lines
src/proxy/processors/push-action/parsePush.ts 0.00% 6 Missing ⚠️
src/db/file/pushes.ts 66.66% 1 Missing and 1 partial ⚠️
.../processors/push-action/checkUserPushPermission.ts 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #973      +/-   ##
==========================================
+ Coverage   48.51%   53.83%   +5.31%     
==========================================
  Files          51       51              
  Lines        2092     2101       +9     
  Branches      241      243       +2     
==========================================
+ Hits         1015     1131     +116     
+ Misses       1040      926     -114     
- Partials       37       44       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kriswest
Copy link
Contributor Author

Code coverage is as good as I can get it, will pick up a little more when #979 is merged

@kriswest
Copy link
Contributor Author

@JamieSlome @coopernetes @grovesy this is ready for a review. I think this will be important to supporting anything other than GitHub (alongside a fix for #950).

@kriswest
Copy link
Contributor Author

@JamieSlome This is the PR we discussed expediting the review of - it'll be needed for supporting git repositories other than Github (work that is going well this week - but will generate another fairly large PR soon).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Commits should be associated with users via email rather than the git user.name config
1 participant
@kriswest
0