feat: add audio settings #909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5991868
Compare
5991868 to
fd2ae43
Compare
|
I just upgraded shlex (v1.2.0) to v1.3.0 to fix the failing task due to the security advisory |
Merged
zicklag
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an "Audio" page to settings with volume controls. It features a main volume slider and sliders to control music and sound effects separately.
This replaces
AudioEventswith a newAudioCenterthat manages all audios (I would've liked to useAudioManagerbut that's taken by bones).before:
after:
For sounds, the volume is calculated as
main_volume * effects_volume * requested_volumewhere the requested volume is the argument toplay_sound. A similar method exists for music.Sound effects are modeled by entities with an
Audiocomponent. When they are stopped/finish the entity is killed. The music system only supported 1 song at a time, so music is stored on theAudioCenteras anOption<Audio>. This can easily be refactored to use entities, like sound effects do, in the future if needed.