8000 Spark range proof verifier unnecessarily reallocates · Issue #1430 · firoorg/firo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Spark range proof verifier unnecessarily reallocates #1430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AaronFeickert opened this issue Apr 9, 2024 · 0 comments · Fixed by #1431
Closed

Spark range proof verifier unnecessarily reallocates #1430

AaronFeickert opened this issue Apr 9, 2024 · 0 comments · Fixed by #1431
Assignees
@AaronFeickert

Comments

@AaronFeickert
Copy link
Contributor

Spark range proofs are verified in batches. To do this, the verifier sets up two large vectors, one for scalars and the other for group elements, for use in a single multiscalar multiplication operation.

However, these vectors don't have their sizes reserved in advance. This means there is likely a fair amount of unnecessary reallocation as elements are pushed.

The solution is to reserve the correct number of elements for each vector.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AaronFeickert AaronFeickert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allocate range proof verifier vectors AaronFeickert/firo
1 participant
@AaronFeickert
0