8000 Allocate range proof verifier vectors by AaronFeickert · Pull Request #1431 · firoorg/firo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Allocate range proof verifier vectors #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2024
Merged

Allocate range proof verifier vectors #1431

merged 1 commit into from
Apr 16, 2024

Conversation

AaronFeickert
Copy link
Contributor

This PR does proper allocation for Spark range proof verifier vectors, which avoids unnecessary reallocation.

You can manually check that the allocation is correct by ensuring that scalars.size() == final_size && points.size() == final_size just before the range proof verifier multiscalar multiplication evaluation.

Closes #1430.

@coderabbitai coderabbitai
Copy link
coderabbitai bot commented Apr 9, 2024 •
edited
Loading

Walkthrough

The modification in bpplus.cpp enhances the efficiency of the Spark range proof verifier by managing the allocation of vectors for multiscalar multiplication. It introduces a final_size variable to optimize the reservation of capacity for points and scalars vectors, aiming to minimize unnecessary reallocations during batch verification.

Changes

File Change Summary
.../bpplus.cpp Introduced final_size for efficient vector capacity management in BPPlus::verify function.

Assessment against linked issues

Objective Addressed Explanation
Reserve correct number of elements for vectors in Spark range proof verifier (#1430) ✅

🐰
In the realms of code, where vectors grow,
A rabbit hopped, with wisdom in tow.
"Reserve, reserve," it whispered light,
For efficiency's sake, in the verifier's night.
Now vectors expand, but just as planned,
A Spark of genius, by the rabbit's hand. 🌟
🐰

Recent Review Status

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 17aab98 and 67e88d2.
Files selected for processing (1)
  • src/libspark/bpplus.cpp (3 hunks)
Additional comments not posted (3)
src/libspark/bpplus.cpp (3)

308-308: Introduce a variable to track the final size of vectors.

This change is crucial for optimizing memory allocation by avoiding unnecessary reallocations.

337-342: Update the final vector size based on the verification process.

Accurately calculating final_size ensures that vectors are allocated with sufficient capacity, enhancing performance.

352-353: Reserve capacity for points and scalars vectors.

Pre-allocating memory for these vectors based on final_size is a significant optimization that can reduce the overhead of dynamic memory allocation.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@reubenyap reubenyap merged commit c22505a into firoorg:master Apr 16, 2024
5 checks passed
@AaronFeickert AaronFeickert deleted the bpplus-allocation branch April 16, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psolstice psolstice psolstice approved these changes

@levonpetrosyan93 levonpetrosyan93 levonpetrosyan93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
v0.14.13.3
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spark range proof verifier unnecessarily reallocates
4 participants
@AaronFeickert @psolstice @levonpetrosyan93 @reubenyap
0