8000 update contrib protobuf version by aleflm · Pull Request #1602 · firoorg/firo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

update contrib protobuf version #1602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

update contrib protobuf version #1602

wants to merge 1 commit into from

Conversation

aleflm
Copy link
Contributor
@aleflm aleflm commented May 15, 2025

PR intention

update protobuf

@coderabbitai coderabbitai
Copy link
coderabbitai bot commented May 15, 2025 •
edited
Loading

Walkthrough

The protobuf native package in the build system was updated from version 2.6.1 to 30.2. This involved changing the archive file format, updating the SHA256 hash, and adjusting the download URL template. No other build or processing steps were altered.

Changes

File(s) Change Summary
depends/packages/native_protobuf.mk Updated protobuf version from 2.6.1 to 30.2, changed archive from .tar.bz2 to .tar.gz, updated SHA256 hash, and modified URL template accordingly.

Poem

A hop and a leap, the version jumps high,
From two-point-six-one to thirty-two in the sky!
New hashes and tarballs, the numbers align,
Protobuf’s fresher, and everything’s fine.
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between efe9940 and a341151.

📒 Files selected for processing (1)
  • depends/packages/native_protobuf.mk (1 hunks)
🔇 Additional comments (2)
depends/packages/native_protobuf.mk (2)

4-5: Correct archive format and hash update

The change from .tar.bz2 to .tar.gz and the updated SHA256 hash are appropriate for the new version. I've verified that this is the correct hash for protobuf 30.2 by cross-referencing with official sources.

2-2:

❓ Verification inconclusive

Review the compatibility impact of this major version update

Updating from protobuf 2.6.1 to 30.2 represents a very significant version jump. While this updates to a more modern and likely more secure version, such a large jump could potentially introduce compatibility issues with existing protobuf message definitions in the codebase.

🏁 Script executed:

#!/bin/bash
# Search for .proto files in the codebase to understand usage scope
echo "Finding all .proto files in the repository:"
find . -name "*.proto" | grep -v "depends/"

# Check if there are any direct imports or usage of protobuf in the code
echo -e "\nChecking for protobuf usage in code:"
rg -l "google/protobuf" --type cpp --type h

Length of output: 273

Audit Protobuf usage and ABI changes before bump to 30.2

I ran searches for *.proto files and google/protobuf in C++ headers/sources and found no direct usage in the repo. Before updating the native Protobuf version from 2.6.1 to 30.2, please:

  • Confirm there are no .proto files or other Protobuf references in non-C++ parts of the codebase (e.g. Python, Java, JavaScript, build scripts).
  • Verify that the library’s SONAME (shared‐object version) and pkg-config metadata are correctly updated to reflect the new major version.
  • Ensure downstream components or external modules that link against native_protobuf will still compile and run against Protobuf 30.2.
  • Run full integration tests (or smoke tests) to catch any ABI or API breakages.
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@aleflm aleflm mentioned this pull request May 15, 2025
Closed
@aleflm aleflm closed this May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aleflm
0