fix all compilation warnings #1618
Open
+1,888
−1,661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated preprocessor checks to use defined macros (Wundef). - Fixed header guards for SECP256K1* (removing _ at the begining because of Wreserved-id-macro / Wreserved-identifier)
- Reordering initiaization order. - Removing unnecessary use of std::move. - Adding missed default operators for classes. - Removing unnecessary namespace. - Adding univalue to bitcoin_util and bitcoin_consensus - Define SECP256K1_BUILD=1 in cmake and use it as header guard for secp256k1.c.
- Creating rpcdump header file for more clarity. - Removing extern or forward declaration and including related header files if needed.
…nused variables/functions.
- Removing unnecessary lock, preventing double locks. - Adding necesarry lock.
… Wrange-loop-analysis. - Renaming compat_macros.h to compat_layer.h. - Creating the `cmp` namespace in `compat_layer.h` with comparison functions and replacing plain comparisons (e.g., `a < b`) with functions defined in `cmp` for ensuring correct comparisons between different types. - Added C++17 requirement to secp256k1 configure.ac - Change some types instead of changing the comparisons.
- Fix Wgnu-folding-constant by moving definition outside of the class. - Fix Wmismatched-tag by changing some classes to struct. - Fix Wbraced-scalar-init by removing initializer list on a pointer.
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 89 files out of 296 files are above the max files limit of 200. You can disable this status message by setting the ✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
levonpetrosyan93
previously approved these changes
Jun 10, 2025
d419da4 to
9f90a21
Compare
|
Updated the PR. Only fixed the merge conflict [1] caused by [2]. No other changes. |
levonpetrosyan93
approved these changes
Jun 30, 2025
aleflm
added a commit
to aleflm/firo
that referenced
this pull request
Jul 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR intention
Fixing compilation warnings.