8000 [firebase_analytics_web] Add missing iOS files by tugorez · Pull Request #2844 · firebase/flutterfire · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[firebase_analytics_web] Add missing iOS files #2844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2020
Merged

[firebase_analytics_web] Add missing iOS files #2844

merged 1 commit into from
Jun 30, 2020

Conversation

tugorez
Copy link
Contributor
@tugorez tugorez commented Jun 25, 2020 •
edited
Loading

Description

We tried to endorse this plugin as the web implementation of firebase_analytics but the integration tests failed due to missing ios files. This PR adds those missing files.

Related Issues

flutter/flutter#45289

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@tugorez tugorez force-pushed the firebase-analytics-web-ios-folders branch from 39e89ec to 6ce21aa Compare June 25, 2020 23:01
@tugorez tugorez marked this pull request as ready for review June 25, 2020 23:05
@tugorez
Copy link
Contributor Author
tugorez commented Jun 25, 2020

cc @ditman

@ditman
Copy link
Contributor
ditman commented Jun 26, 2020 •
edited
Loading

Looks like there's a test failing in the firebase_analytics package? Can you take a look?

00:09 +4: /tmp/cirrus-ci-build/packages/firebase_analytics/firebase_analytics/test/observer_test.dart: FirebaseAnalyticsObserver handles only PlatformExceptions                                       
00:09 +4 -1: /tmp/cirrus-ci-build/packages/firebase_analytics/firebase_analytics/test/observer_test.dart: FirebaseAnalyticsObserver handles only PlatformExceptions [E]                                
  Invalid argument(s)
  package:mockito/src/mock.dart 342:7                       PostExpectation.thenThrow.<fn>
  package:mockito/src/mock.dart 119:45                      Mock.noSuchMethod
  package:firebase_analytics/firebase_analytics.dart 83:16  MockFirebaseAnalytics.setCurrentScreen
  package:firebase_analytics/observer.dart 80:17            FirebaseAnalyticsObserver._sendScreenView
  package:firebase_analytics/observer.dart 97:7             FirebaseAnalyticsObserver.didPush
  observer_test.dart 98:29                                  main.<fn>.<fn>.<fn>
  package:test_api                                          expect
  package:flutter_test/src/widget_tester.dart 369:3         expect
  observer_test.dart 98:7                                   main.<fn>.<fn>
  observer_test.dart 85:48                                  main.<fn>.<fn>
  ===== asynchronous gap ===========================
  dart:async                                                _AsyncAwaitCompleter.completeError
  package:firebase_analytics/firebase_analytics.dart        MockFirebaseAnalytics.setCurrentScreen
  package:firebase_analytics/observer.dart 80:17            FirebaseAnalyticsObserver._sendScreenView
  package:firebase_analytics/observer.dart 97:7             FirebaseAnalyticsObserver.didPush
  observer_test.dart 98:29                                  main.<fn>.<fn>.<fn>
  package:test_api                                          expect
  package:flutter_test/src/widget_tester.dart 369:3         expect
  observer_test.dart 98:7                                   main.<fn>.<fn>
  observer_test.dart 85:48                                  main.<fn>.<fn>
  Expected: throws <Instance of 'ArgumentError'>
    Actual: <Closure: () => void>
     Which: returned <null>
  package:t
8000
est_api                                   expect
  package:flutter_test/src/widget_tester.dart 369:3  expect
  observer_test.dart 98:7                            main.<fn>.<fn>
  observer_test.dart 85:48                           main.<fn>.<fn>

@tugorez tugorez mentioned this pull request Jun 26, 2020
Closed
@ditman
Copy link
Contributor
ditman commented Jun 29, 2020

The failing test has been disabled in master. Can you rebase this and try again, please?

@tugorez tugorez force-pushed the firebase-analytics-web-ios-folders branch from 6ce21aa to 95496f2 Compare June 29, 2020 21:37
@kroikie kroikie requested a review from ditman June 29, 2020 22:48
@tugorez
Copy link
Contributor Author
tugorez commented Jun 29, 2020
8000

Done @ditman. Everything looks great :)!

ditman
ditman approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor
@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's publish this and see if we can endorse the pkg!

@ditman ditman merged commit acca7ef into firebase:master Jun 30, 2020
@ditman
Copy link
Contributor
ditman commented Jun 30, 2020

Published and tagged firebase_analytics_web version 0.1.1

@firebase firebase locked and limited conversation to collaborators Jul 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ditman ditman ditman approved these changes

Assignees

@ditman ditman

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tugorez @ditman @googlebot
0