8000 Provide full path to volume by arsenii-firebolt · Pull Request #15 · firebolt-db/firebolt-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Provide full path to volume #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 7, 2025
Merged

Provide full path to volume #15

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e1c10b
Provide full path to volume
arsenii-firebolt Jun 30, 2025
24f8990
Update get-core.sh
arsenii-firebolt Jun 30, 2025
63dc6b1
Update get-core.sh
arsenii-firebolt Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
8000
Diff view
15 changes: 12 additions & 3 deletions get-core.sh
View file
Open in desktop
8000
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,16 @@ banner() {
# Docker image to pull
DOCKER_IMAGE="ghcr.io/firebolt-db/firebolt-core:preview-rc"
EXTERNAL_PORT=3473
DOCKER_RUN_ARGS="-i --name firebolt-core --rm --ulimit memlock=8589934592:8589934592 --security-opt seccomp=unconfined -v ./firebolt-core-data:/firebolt-core/volume -p $EXTERNAL_PORT:3473 $DOCKER_IMAGE"
DOCKER_RUN_ARGS=(
-i
--name firebolt-core
--rm
--ulimit memlock=8589934592:8589934592
--security-opt seccomp=unconfined
-v "$(pwd)/firebolt-core-data:/firebolt-core/volume"
-p "$EXTERNAL_PORT:3473"
"$DOCKER_IMAGE"
)

ensure_docker_is_installed() {
if docker info >/dev/null 2>&1; then
Expand Down Expand Up @@ -113,7 +122,7 @@ run_docker_image() {
case "$answer" in
[yY])
echo -n "[🔥] Starting the Firebolt Core Docker container"
CID="$(docker run --detach $DOCKER_RUN_ARGS)"
CID="$(docker run --detach "${DOCKER_RUN_ARGS[@]}")"
trap "docker kill $CID" EXIT
echo " ✅"

Expand All @@ -125,7 +134,7 @@ run_docker_image() {
*)
echo "[🔥] Firebolt Core is ready to be executed, you can do this by running the following command:"
echo
echo "docker run --name firebolt-core $DOCKER_RUN_ARGS"
echo "docker run "${DOCKER_RUN_ARGS[@]}""
echo
echo "And then in another terminal:"
echo
Expand Down
0