Fix moduli computation in example #350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes flatsurf#235. https://arxiv.org/pdf/1411.1827 Definition 3.3 defines the moduli as h/c where c is the circumference so we want to follow that definition. Note that we use that correct definition in gl2r_orbit_closure.py ```py width = self.V2._isomorphic_vector_space.base_ring()( self.V2.base_ring()(component.width()) ) height = self.V2._isomorphic_vector_space.base_ring()( self.V2.base_ring()( component.vertical().project(component.circumferenceHolonomy()) ) ) module_fractions.append((width, height)) ``` What's confusing is that "height" is the circumference here and width is what is called height in the article (in the article, the flow is to the right, for us the flow is usually north.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #235. https://arxiv.org/pdf/1411.1827 Definition 3.3 defines the moduli as h/c where c is the circumference so we want to follow that definition.
Note that we use that correct definition in gl2r_orbit_closure.py
What's confusing is that "height" is the circumference here and width is what is called height in the article (in the article, the flow is to the right, for us the flow is usually north.)
Checklist
doc/news/. I don't think this is newsworthy in any way.doc/geometryordoc/graphical. Nothing new.