fix(storage): map protobuf enums to ints in sql updates for rule and rollout #4231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rollout Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4231 +/- ##
=======================================
Coverage 63.67% 63.67%
=======================================
Files 171 171
Lines 17528 17528
=======================================
Hits 11161 11161
Misses 5701 5701
Partials 666 666
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
markphelps
added a commit
that referenced
this pull request
May 21, 2025
* main: (26 commits) chore: test with prepared statements off for pg (#4233) fix(storage): map protobuf enums to ints in sql updates for rule and (#4231) fix(audit): keep segment data for rollout and rule (#4229) chore(deps): bump codecov/codecov-action from 5.4.2 to 5.4.3 (#4214) chore(deps): bump github.com/open-policy-agent/opa from 1.4.0 to 1.4.2 (#4216) chore(deps): bump github.com/xo/dburl from 0.23.4 to 0.23.7 (#4217) chore(deps): bump go.opentelemetry.io/contrib/instrumentation/runtime (#4218) chore(deps): bump github.com/aws/aws-sdk-go-v2/service/s3 (#4219) chore(deps): bump @loadable/component from 5.16.4 to 5.16.7 in /ui (#4224) chore(deps-dev): bump vite from 6.3.4 to 6.3.5 in /ui (#4220) chore(deps): bump @tanstack/react-table from 8.21.2 to 8.21.3 in /ui (#4223) chore(deps): bump chart.js from 4.4.8 to 4.4.9 in /ui (#4222) chore(deps): bump @radix-ui/react-select from 2.1.7 to 2.2.4 in /ui (#4221) chore(deps): bump github.com/golang-migrate/migrate/v4 (#4215) chore(deps): bump golang.org/x/tools from 0.32.0 to 0.33.0 in /_tools (#4199) chore(deps): bump golang.org/x/crypto from 0.37.0 to 0.38.0 (#4192) chore(deps): bump github.com/go-sql-driver/mysql from 1.9.1 to 1.9.2 (#4189) chore(deps): bump cloud.google.com/go/storage from 1.51.0 to 1.53.0 (#4193) chore(deps): bump zod from 3.24.3 to 3.24.4 in /ui (#4195) chore(deps): bump react-router from 7.5.3 to 7.6.0 in /ui (#4196) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original fix was done in #3454 but updating rollout and rules were not resolved
closes #4230