8000 Comments in Waveform · Issue #97 · flpa/mcs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Comments in Waveform #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
8000
Open
kamejosh opened this issue Feb 21, 2016 · 4 comments
Open

Comments in Waveform #97

kamejosh opened this issue Feb 21, 2016 · 4 comments
Assignees
@kamejosh
Labels
enhancement
Milestone
v1.1.0

Comments

@kamejosh
Copy link
Collaborator

Comments can be added to the waveform, so they have a time attached and you can comment on specific parts of the mix.
@kamejosh kamejosh added this to the v1.1.0 milestone Feb 21, 2016
@kamejosh
Copy link
Collaborator Author

comments can now be added with clicking on the waveform while holding down the "c" key.
Things that still need to be fixed:

  • textfield for entering the comment should be focused
  • comments should maintain their relative position
  • comments should be saved with the project

@kamejosh
Copy link
Collaborator Author

comments now maintain their relative position
pushed to new online branch, so you can see how it looks

kamejosh pushed a commit that referenced this issue Feb 22, 2016
comments work now but still need some fixing. for more detailed infor…
407c91d 
…mation see issue #97
@kamejosh
Copy link
Collaborator Author

comments can now deleted by clicking a comment and then pressing backspace (see commit #b812f9d)

@kamejosh kamejosh self-assigned this Feb 22, 2016
@kamejosh
Copy link
Collaborator Author

textfield is now focused on creating a new comment

kamejosh pushed a commit that referenced this issue Feb 23, 2016
changed the key for making coments to SHIFT, and increased the time f…
3212358 
…or a tooltip to be shown. issue #97
kamejosh pushed a commit that referenced this issue Feb 23, 2016
fixed a bug that once SHIFT was pressed every click on the waveform r…
16067ea 
…esulted in a comment. issue #97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kamejosh kamejosh

Labels
enhancement
Projects
None yet
Milestone
v1.1.0
Development

No branches or pull requests
1 participant
@kamejosh
0