8000 SC action: add input to select SC branch by weefuzzy · Pull Request #6 · flucoma/actions · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

SC action: add input to select SC branch #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

SC action: add input to select SC branch #6

wants to merge 1 commit into from

Conversation

weefuzzy
Copy link
Member
@weefuzzy weefuzzy commented Jun 9, 2025

Because of changes to SC in relation to our code crimes, we will need to be selective about which SC branch(es) we're releasing against, rather than just tugging on main. Furthermore, we might want to support dual releases during 3.13 to 3.14 transition (and again for 3.15).

@weefuzzy weefuzzy requested a review from jamesb93 June 9, 2025 16:16
tremblap
tremblap reviewed Jun 9, 2025
View reviewed changes
Copy link
Member
@tremblap tremblap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would that mean we can trigger 2 set of binaries?

sc/action.yaml
@@ -13,6 +13,10 @@ inputs:
description: 'Select a specific branch for flucoma-core'
required: false
default: 'main'
sc_branch:
description: 'Select an SC branch to use'
requireed: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo here? required?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, typo

jamesb93
jamesb93 approved these changes Jun 10, 2025
View reviewed changes
Copy link
Member
@jamesb93 jamesb93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

sc/action.yaml
@@ -13,6 +13,10 @@ inputs:
description: 'Select a specific branch for flucoma-core'
required: false
default: 'main'
sc_branch:
description: 'Select an SC branch to use'
requireed: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, typo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremblap tremblap tremblap left review comments

@jamesb93 jamesb93 jamesb93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weefuzzy @tremblap @jamesb93
0