8000 Fix/scaler invert by weefuzzy · Pull Request #95 · flucoma/flucoma-sc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix/scaler invert #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 11, 2022
Merged

Fix/scaler invert #95

merged 2 commits into from
May 11, 2022

Conversation

weefuzzy
Copy link
Member
@weefuzzy weefuzzy commented May 3, 2022
  • Replaces invert parameters in scalers with inverseTransform<Point> messages
  • Works around character limit in SC plugin command names (can't reliably truncate, so remove all vowels instead 💩 )

weefuzzy added 2 commits May 3, 2022 16:50
@weefuzzy
All scalers: replace 'invert' parameter with inverseTransform messages
< 8000 batch-deferred-content class="d-inline-block" data-url="/flucoma/flucoma-sc/commits/checks-statuses-rollups">
d3f56ab
@weefuzzy
Wrapper: Work around 32 char limit for plugin commands
11d07c4 
If too long, remove vowels. 
Sorry. 
Better ideas welcome
@weefuzzy weefuzzy requested review from tedmoore and tremblap May 3, 2022 15:54
@tremblap tremblap added this to the beta7 milestone May 10, 2022
@weefuzzy weefuzzy merged commit ddb039e into flucoma:dev May 11, 2022
@weefuzzy weefuzzy deleted the fix/scaler-invert branch May 11, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tedmoore tedmoore Awaiting requested review from tedmoore

@tremblap tremblap Awaiting requested review from tremblap

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
beta7
Development

Successfully merging this pull request may close these issues.
2 participants
@weefuzzy @tremblap
0