8000 out_s3: fix the error message of total_file_size limit when use_put_object is enabled by tenkirin · Pull Request #10470 · fluent/fluent-bit · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

out_s3: fix the error message of total_file_size limit when use_put_object is enabled #10470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

out_s3: fix the error message of total_file_size limit when use_put_object is enabled #10470

wants to merge 1 commit into from

Conversation

tenkirin
Copy link

Background

This PR fixes a bug in the S3 Output plugin related to the total_file_size error message.

Although the actual limit is 1GB (MAX_FILE_SIZE_PUT_OBJECT), the error message still incorrectly states it as "50M".

This PR updates the error message to reflect the current limit, following the same approach used for MAX_FILE_SIZE to ensure consistency across the codebase.

Testing

Below is an excerpt from the output of run_code_analysis.sh:

[plugins/out_s3/]
s3.c                                           |39.2%  1155|53.3%  30|    -    0
s3_multipart.c                                 |49.0%   357|78.6%  14|    -    0
s3_store.c                                     |66.7%   231|84.2%  19|    -    0
================================================================================
                                         Total:|32.8%  379k|37.6% 24k|    -    0
::endgroup::
+ rm -f /tmp/tmp.keCsSwAMHq
+ exit 0

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@tenkirin tenkirin requested a review from PettitWesley as a code owner June 13, 2025 11:00
@tenkirin tenkirin changed the title out_s3: fix the error message of total_file_size limit when use_put_o… out_s3: fix the error message of total_file_size limit when use_put_object is enabled Jun 13, 2025
@tenkirin
Copy link
Author

@sparrc @singholt @swapneils
It seems that @PettitWesley is not active, and I'm unable to update the reviewers. Just FYI. Apologies if this is not relevant to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PettitWesley PettitWesley Awaiting requested review from PettitWesley PettitWesley is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
docs-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tenkirin
0