8000 Migrate layout/ to null safety by amanv8060 · Pull Request #578 · flutter/gallery · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Jun 13, 2024. It is now read-only.

Migrate layout/ to null safety #578

Merged
merged 5 commits into from
Jan 4, 2022
Merged

Migrate layout/ to null safety #578

merged 5 commits into from
Jan 4, 2022

Conversation

amanv8060
Copy link
Contributor
@amanv8060 amanv8060 commented Dec 31, 2021 •
edited
Loading
  • Opts out every file from null-safety
  • Migrates layout/ to null-safety

part of #527

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@amanv8060
Copy link
Contributor Author
amanv8060 commented Dec 31, 2021 •
edited
Loading

@guidezpl please review, will ask test exemption based on this Tree-Hygiene after tests are successful.

guidezpl
guidezpl suggested changes Dec 31, 2021
View reviewed changes
Copy link
Member
@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  _    ___ _____ __  __ 
 | |  / __|_   _|  \/  |
 | |_| (_ | | | | |\/| |
 |____\___| |_| |_|  |_|

Thanks! These PRs will be exempt from the need to add new tests.

amanv8060
amanv8060 commented Dec 31, 2021
View reviewed changes
tool/codeviewer_cli/segment_generator.dart
@@ -19,6 +22,8 @@ const _globalPrologue =
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// @dart=2.9
Copy link
Contributor Author
@amanv8060 amanv8060 Dec 31, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guidezpl , added dart version here in generator until code_style.dart is not migrated, to fix analyzer issue

@amanv8060 amanv8060 requested a review from guidezpl January 3, 2022 06:09
@guidezpl
Copy link
Member
guidezpl commented Jan 3, 2022

#577 will have to be merged before this PR can be

@guidezpl guidezpl merged commit 4e28f7a into flutter:master Jan 4, 2022
@amanv8060 amanv8060 deleted the layout-null-safety branch January 4, 2022 17:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guidezpl guidezpl guidezpl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amanv8060 @guidezpl
0