8000 Include a flutter preview device with the Flutter SDK that supports hot reload · Issue #130277 · flutter/flutter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Include a flutter preview device with the Flutter SDK that supports hot reload #130277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
4 of 8 tasks
christopherfujino opened this issue Jul 10, 2023 · 3 comments · Fixed by #135639
Open
4 of 8 tasks

Include a flutter preview device with the Flutter SDK that supports hot reload #130277

christopherfujino opened this issue Jul 10, 2023 · 3 comments · Fixed by #135639
Labels
P2 Important issues not at the top of the work list team-tool Owned by Flutter Tool team tool Affects the "flutter" command-line tool. See also t: labels. triaged-tool Triaged by Flutter Tool team

Comments

@christopherfujino
Copy link
Contributor
christopherfujino commented Jul 10, 2023 •
edited
Loading

Use case

This would allow new Flutter developers to experience Flutter's hot reload developer experience before installing a native build toolchain (such as Xcode, or Visual Studio).
@christopherfujino christopherfujino added tool Affects the "flutter" command-line tool. See also t: labels. P1 High-priority issues at the top of the work list labels Jul 10, 2023
@christopherfujino christopherfujino self-assigned this Jul 10, 2023
@christopherfujino christopherfujino added the team-tool Owned by Flutter Tool team label Jul 11, 2023
@christopherfujino christopherfujino added the triaged-tool Triaged by Flutter Tool team label Sep 26, 2023
@christopherfujino christopherfujino mentioned this issue Oct 10, 2023
Merged
@andrewkolos
Copy link
Contributor

@christopherfujino Is this a dupe of #85329?

@christopherfujino christopherfujino mentioned this issue Oct 11, 2023
Closed
3 tasks
@christopherfujino
Copy link
Contributor Author

@christopherfujino Is this a dupe of #85329?

good catch, closed that in favor of this one, as it more closely reflects the steps I'm working on.

auto-submit bot pushed a commit that referenced this issue Oct 18, 2023
@christopherfujino
Flutter preview device (#135639)
8a31a3a 
Fixes #130277

This PR does two things:

1. introduce a hidden `flutter build _preview` command, that will build a debug windows desktop app and copy it into the SDK's binary cache. This command is only intended to be run during packaging.
2. introduce a new device type, called `PreviewDevice`, which relies on the prebuilt desktop debug app from step 1, copies it into the target app's assets build folder, and then hot reloads their dart code into it.
@github-actions GitHub Actions
Copy link
github-actions bot commented Nov 1, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2023
@christopherfujino christopherfujino mentioned this issue Nov 6, 2023
Merged
@flutter-triage-bot flutter-triage-bot bot unlocked this conversation Nov 8, 2023
arpitgandhi9 pushed a commit to arpitgandhi9/flutter that referenced this issue Nov 8, 2023
@christopherfujino
[flutter_tools] toolexit when using plugins with preview device (flut…
d550ba5 
…ter#136936)

Part of flutter#130277

Without this, if a user runs an app that has plugins that call method channels with the `preview` device, the app will build successfully, however, they will get a runtime error when their dart code tries to call the method channel that does not exist in the native build (which was pre-built and thus does not include the plugin code).

This change adds a validation when injecting plugins that will tool exit if the device-id is `preview` and their project contains plugins with method channels.
@loic-sharma loic-sharma mentioned this issue Dec 12, 2023
Open
@christopherfujino christopherfujino mentioned this issue Dec 16, 2023
Merged
auto-submit bot pushed a commit that referenced this issue Dec 21, 2023
8000
@christopherfujino
[flutter_tools] Ensure flutter daemon clients can detect preview devi…
674fbd2 
…ce (#140112)

Part of #130277
CoderDake pushed a commit to CoderDake/flutter that referenced this issue Dec 28, 2023
@christopherfujino @CoderDake
[flutter_tools] Ensure flutter daemon clients can detect preview devi…
24569fc 
…ce (flutter#140112)

Part of flutter#130277
@christopherfujino christopherfujino removed their assignment May 30, 2024
@christopherfujino christopherfujino added P2 Important issues not at the top of the work list and removed P1 High-priority issues at the top of the work list labels May 30, 2024
@christopherfujino christopherfujino mentioned this issue Jun 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 Important issues not at the top of the work list team-tool Owned by Flutter Tool team tool Affects the "flutter" command-line tool. See also t: labels. triaged-tool Triaged by Flutter Tool team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Flutter preview device chris-forks/flutter
2 participants
@christopherfujino @andrewkolos
0