8000 integration_tests: Check if BuildContext is mounted in display_cutout_test by srawlins · Pull Request #169008 · flutter/flutter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

integration_tests: Check if BuildContext is mounted in display_cutout_test #169008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2025
Merged

integration_tests: Check if BuildContext is mounted in display_cutout_test #169008

merged 1 commit into from
May 29, 2025

Conversation

srawlins
Copy link
Contributor
@srawlins srawlins commented May 16, 2025 •
edited
Loading

These changes highlight where code was not safely checking whether the BuildContext was mounted before using it.

The use_build_context_synchronously lint rule is changing to catch these cases.

Pre-launch Checklist

@srawlins srawlins enabled auto-merge May 16, 2025 20:55
@srawlins
Copy link
Contributor Author

Is there a process for getting a PR reviewed?

@srawlins srawlins added this pull request to the merge queue May 28, 2025
auto-merge was automatically disabled May 28, 2025 22:29

Pull Request is not mergeable

Merged via the queue into master with commit 1ce59f4 May 29, 2025
154 checks passed
@srawlins srawlins deleted the ubcs-integration-tests branch May 29, 2025 03:15
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
706b179 
…lay_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
b471fe7 
…lay_cutout_test (flutter/flutter#169008)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
3dafb46 
…lay_cutout_test (flutter/flutter#169008)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
9bde403 
…lay_cutout_test (flutter/flutter#169008)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
52ad8f7 
…lay_cutout_test (flutter/flutter#169008)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
75a7604 
…lay_cutout_test (flutter/flutter#169008)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
70681c2 
…lay_cutout_test (flutter/flutter#169008)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
4326c62 
…lay_cutout_test (flutter/flutter#169008)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
835e3ab 
…lay_cutout_test (flutter/flutter#169008)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
37ecc13 
…lay_cutout_test (flutter/flutter#169008)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
db903c8 
…lay_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
28ae8ab 
…lay_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
9d51e2d 
…lay_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
5cf7e09 
…lay_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
2fb715a 
…lay_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
7859dee 
…lay_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
20ced9c 
…lay_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
cd75adb 
…lay_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
141b123 
…lay_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
ec4154c 
…lay_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
d1e73f0 
…lay_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
53e55ba 
…lay_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
39f56a3 
…lay_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
25c1836 
…lay_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
fdbdc34 
…lay_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
a2cc8f2 
…lay_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
4d3681c 
…lay_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
3242980 
…lay_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
6da278b 
…lay_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
04a0789 
…lay_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
a963022 
…lay_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
cee1116 
…lay_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
3f03e63 
…lay_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
a83a25c 
…lay_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
06f1fb5 
…lay_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
27fe6dc 
…lay_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
dbb32a1 
…lay_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
cb6b530 
…lay_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
dec8eb7 
…lay_cutout_test (flutter/flutter#169008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
1ce59f419 integration_tests: Check if BuildContext is mounted in disp…
91ab20d 
…lay_cutout_test (flutter/flutter#169008)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matanlurey matanlurey matanlurey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srawlins @matanlurey
0