Fix: Update anchorRect for overlayBuilder when anchor moves #169814
+61
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SchedulerBinding.instance.addPostFrameCallback((Duration timestamp) {
if (!mounted || !_overlayController.isShowing) {
return;
}
if (info != _getRawMenuOverlayInfo(context)) {
// Rebuild overlayBuilder
_overlayController.hide();
_overlayController.show();
}
});Somehow being callback inside build method, I am not feeling good + the way I am rebuilding overlay. I would love to hear feedback, how we can achieve this otherwise. |
3155855 to
a681e98
Compare
Piinks
reviewed
Jun 18, 2025
|
|
||
| Widget _buildOverlay(BuildContext context) { | ||
| final RawMenuOverlayInfo info = _getRawMenuOverlayInfo(context); | ||
| SchedulerBinding.instance.addPostFrameCallback((Duration timestamp) { |
There was a problem hiding this comment.
Does this always need to be in a postframe callback?
There was a problem hiding this comment.
Yes because otherwise we always use older anchorRect.
Also if overlay is opened in first frame, it will open at (0,0).
Because logically first anchor should settle down its position then overlayBuilder should lay itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Update anchorRect for overlayBuilder when anchor moves
fixes: #169457
Pre-launch Checklist
///).