8000 Remove `pubspec.lock` files for `flutter_tools` and `widget_preview_scaffold`. by matanlurey · Pull Request #170364 · flutter/flutter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove pubspec.lock files for flutter_tools and widget_preview_scaffold. #170364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 10, 2025
Merged

Remove pubspec.lock files for flutter_tools and widget_preview_scaffold. #170364

merged 2 commits into from
Jun 10, 2025
+4 −1,182

Conversation

matanlurey
Copy link
Contributor

Closes #170264.

I believe these files were accidentally introduced in #168662, as part of the workspace-ifying of flutter/flutter; these two packages are not part of the workspace, and there is special logic in bin/internal/shared.sh (i.e. the entrypoint to flutter) that expects this file to be updated:

flutter/bin/internal/shared.sh

Line 131 in 2d30ce5

"$FLUTTER_TOOLS_DIR/pubspec.yaml" -nt "$FLUTTER_TOOLS_DIR/pubspec.lock" ]]; then

We can revisit this if the pub team has advice on what to do; for now helps the periodic failures described in #170264.

@matanlurey matanlurey requested a review from jtmcdole June 10, 2025 17:10
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 10, 2025
jtmcdole
jtmcdole approved these changes Jun 10, 2025
View reviewed changes
Copy link
Member
@jtmcdole jtmcdole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please

jonahwilliams
jonahwilliams approved these changes Jun 10, 2025
View reviewed changes
Copy link
Member
@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 10, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jun 10, 2025
Merged via the queue into flutter:master with commit 70a7805 Jun 10, 2025
142 of 143 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 10, 2025
@matanlurey matanlurey mentioned this pull request Jun 10, 2025
Open
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 12, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 12, 2025
@engine-flutter-autoroll
70a780548 Remove pubspec.lock files for flutter_tools and `widget…
f4c971c 
…_preview_scaffold`. (flutter/flutter#170364)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jun 12, 2025
@engine-flutter-autoroll
Roll Flutter from 824868f5d1e6 to f79452e3f4ea (94 revisions) (#9419)
f7b32d9 
Roll Flutter from 824868f5d1e6 to f79452e3f4ea (94 revisions)

flutter/flutter@824868f...f79452e

2025-06-12 engine-flutter-autoroll@skia.org Roll Skia from 38b9f9b0e496 to b41e7017658e (12 revisions) (flutter/flutter#170514)
2025-06-12 rmolivares@renzo-olivares.dev Fix `Semantics.identifier` on TextField not working on web (flutter/flutter#170395)
2025-06-12 jhy03261997@gmail.com Revert "[a11y] Semantics flag refactor step 2: embedder part" (flutter/flutter#170498)
2025-06-12 matanlurey@users.noreply.github.com Copy `packages_autoroller` to `dev/packages_autoroller/run`. (flutter/flutter#170495)
2025-06-11 ybz975218925@gmail.com Allow the Slider to always show the value indicator. (flutter/flutter#162223)
2025-06-11 matanlurey@users.noreply.github.com Update master branch `CHANGELOG.md` for 3.32.3. (flutter/flutter#170492)
2025-06-11 louisehsu@google.com Add time to first frame for `Mac_arm64_ios imitation_game_swiftui` (flutter/flutter#167602)
2025-06-11 103958012+ahmedrasar@users.noreply.github.com Make `DropdownMenu` TextField reactive to label changes (flutter/flutter#162062)
2025-06-11 engine-flutter-autoroll@skia.org Roll Dart SDK from b569246d64bc to 9f741ef8a689 (1 revision) (flutter/flutter#170473)
2025-06-11 jonahwilliams@google.com [impellerc] add GLES shader define. (flutter/flutter#170375)
2025-06-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Pause UIScene migration (#170457)" (flutter/flutter#170487)
2025-06-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix DropdownButtonFormField focusing when replacing FocusNode (#166645)" (flutter/flutter#170477)
2025-06-11 15619084+vashworth@users.noreply.github.com Pause UIScene migration (flutter/flutter#170457)
2025-06-11 15619084+vashworth@users.noreply.github.com iOS tool dylibs do not need entitlements (flutter/flutter#170448)
2025-06-11 15619084+vashworth@users.noreply.github.com Adds getters for different formats of build mode name (flutter/flutter#170251)
2025-06-11 matanlurey@users.noreply.github.com Remove all code in `conductor/core` that is now unused (flutter/flutter#170454)
2025-06-11 engine-flutter-autoroll@skia.org Roll Packages from 974f152 to 0b322a2 (9 revisions) (flutter/flutter#170462)
2025-06-11 engine-flutter-autoroll@skia.org Roll Skia from b78fdc3ba26b to 38b9f9b0e496 (7 revisions) (flutter/flutter#170453)
2025-06-11 pogojotz@gmx.net Fix remaining iconbuttontheme overrides in listtile (flutter/flutter#169029)
2025-06-11 ahmedelsaayid@gmail.com Fix DropdownButtonFormField focusing when replacing FocusNode (flutter/flutter#166645)
2025-06-11 737941+loic-sharma@users.noreply.github.com Add CupertinoRadio widget of the week video (flutter/flutter#170027)
2025-06-11 34465683+rkishan516@users.noreply.github.com Docs: Update docs for suffix icon interaction behaviour (flutter/flutter#169828)
2025-06-11 bkonyi@google.com [ Widget Preview ] Don't try to load previews with compile-time errors (flutter/flutter#170262)
2025-06-11 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Manually trigger `input` event in text editing tests for Safari (flutter/flutter#170022)
2025-06-11 pateltirth454@gmail.com Tiny clean-up in triage docs (flutter/flutter#170429)
2025-06-11 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#170444)
2025-06-11 flar@google.com [Impeller] Avoid creating paths when rendering arcs (flutter/flutter#170398)
2025-06-11 bruno.leroux@gmail.com Fix date picker calendar tap targets (portrait mode) (flutter/flutter#169163)
2025-06-11 fmalita@gmail.com Add SK_SUPPORT_UNSPANNED_APIS staging flag (flutter/flutter#170139)
2025-06-11 engine-flutter-autoroll@skia.org Roll Dart SDK from 6290dfd1d88a to b569246d64bc (4 revisions) (flutter/flutter#170430)
2025-06-11 engine-flutter-autoroll@skia.org Roll Skia from 910070084066 to b78fdc3ba26b (33 revisions) (flutter/flutter#170412)
2025-06-11 kjlubick@users.noreply.github.com Use pathops module groups (flutter/flutter#169857)
2025-06-10 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#170399)
2025-06-10 1961493+harryterkelsen@users.noreply.github.com Verify old version of Python has the `lib2to3` import available (flutter/flutter#170187)
2025-06-10 jason-simmons@users.noreply.github.com Use "flutter pub get" to resolve packages when building the docs snippets tool (flutter/flutter#170381)
2025-06-10 jonahwilliams@google.com [engine] Reland: ensure engines spawned from an engine using dynamic rendering selection still use the dynamic surface. (flutter/flutter#170389)
2025-06-10 jiahaog@users.noreply.github.com Revert "Add call to Dart_NotifyDestroyed when the flutter view is des… (flutter/flutter#170309)
2025-06-10 luca.randazzo@protonmail.com fix: set versionCodeOverride when split-per-abi is specified (flutter/flutter#169816)
2025-06-10 codefu@google.com fix: Skip native assets build test (flaky, takes 15m+) (flutter/flutter#170383)
2025-06-10 fluttergithubbot@gmail.com Marks Linux web_benchmarks_ddc to be unflaky (flutter/flutter#167631)
2025-06-10 fluttergithubbot@gmail.com Marks Linux web_benchmarks_ddc_hot_reload to be unflaky (flutter/flutter#168807)
2025-06-10 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[engine] ensure engines spawned from an engine using dynamic rendering selection still use the dynamic surface. (#170313)" (flutter/flutter#170377)
2025-06-10 jhy03261997@gmail.com [a11y] Semantics flag refactor step 2: embedder part (flutter/flutter#167738)
2025-06-10 engine-flutter-autoroll@skia.org Roll Dart SDK from c26e7ca44805 to 6290dfd1d88a (5 revisions) (flutter/flutter#170363)
2025-06-10 matanlurey@users.noreply.github.com Remove `pubspec.lock` files for `flutter_tools` and `widget_preview_scaffold`. (flutter/flutter#170364)
2025-06-10 jonahwilliams@google.com [engine] ensure engines spawned from an engine using dynamic rendering selection still use the dynamic surface. (flutter/flutter#170313)
...
feduke-nukem pushed a commit to Yobari-Timeliners/golub that referenced this pull request Jun 13, 2025
@engine-flutter-autoroll
Roll Flutter from 824868f5d1e6 to f79452e3f4ea (94 revisions) (#9419)
3bfd8f7 
Roll Flutter from 824868f5d1e6 to f79452e3f4ea (94 revisions)

flutter/flutter@824868f...f79452e

2025-06-12 engine-flutter-autoroll@skia.org Roll Skia from 38b9f9b0e496 to b41e7017658e (12 revisions) (flutter/flutter#170514)
2025-06-12 rmolivares@renzo-olivares.dev Fix `Semantics.identifier` on TextField not working on web (flutter/flutter#170395)
2025-06-12 jhy03261997@gmail.com Revert "[a11y] Semantics flag refactor step 2: embedder part" (flutter/flutter#170498)
2025-06-12 matanlurey@users.noreply.github.com Copy `packages_autoroller` to `dev/packages_autoroller/run`. (flutter/flutter#170495)
2025-06-11 ybz975218925@gmail.com Allow the Slider to always show the value indicator. (flutter/flutter#162223)
2025-06-11 matanlurey@users.noreply.github.com Update master branch `CHANGELOG.md` for 3.32.3. (flutter/flutter#170492)
2025-06-11 louisehsu@google.com Add time to first frame for `Mac_arm64_ios imitation_game_swiftui` (flutter/flutter#167602)
2025-06-11 103958012+ahmedrasar@users.noreply.github.com Make `DropdownMenu` TextField reactive to label changes (flutter/flutter#162062)
2025-06-11 engine-flutter-autoroll@skia.org Roll Dart SDK from b569246d64bc to 9f741ef8a689 (1 revision) (flutter/flutter#170473)
2025-06-11 jonahwilliams@google.com [impellerc] add GLES shader define. (flutter/flutter#170375)
2025-06-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Pause UIScene migration (#170457)" (flutter/flutter#170487)
2025-06-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix DropdownButtonFormField focusing when replacing FocusNode (#166645)" (flutter/flutter#170477)
2025-06-11 15619084+vashworth@users.noreply.github.com Pause UIScene migration (flutter/flutter#170457)
2025-06-11 15619084+vashworth@users.noreply.github.com iOS tool dylibs do not need entitlements (flutter/flutter#170448)
2025-06-11 15619084+vashworth@users.noreply.github.com Adds getters for different formats of build mode name (flutter/flutter#170251)
2025-06-11 matanlurey@users.noreply.github.com Remove all code in `conductor/core` that is now unused (flutter/flutter#170454)
2025-06-11 engine-flutter-autoroll@skia.org Roll Packages from 974f1522ee03 to 17c02a5 (9 revisions) (flutter/flutter#170462)
2025-06-11 engine-flutter-autoroll@skia.org Roll Skia from b78fdc3ba26b to 38b9f9b0e496 (7 revisions) (flutter/flutter#170453)
2025-06-11 pogojotz@gmx.net Fix remaining iconbuttontheme overrides in listtile (flutter/flutter#169029)
2025-06-11 ahmedelsaayid@gmail.com Fix DropdownButtonFormField focusing when replacing FocusNode (flutter/flutter#166645)
2025-06-11 737941+loic-sharma@users.noreply.github.com Add CupertinoRadio widget of the week video (flutter/flutter#170027)
2025-06-11 34465683+rkishan516@users.noreply.github.com Docs: Update docs for suffix icon interaction behaviour (flutter/flutter#169828)
2025-06-11 bkonyi@google.com [ Widget Preview ] Don't try to load previews with compile-time errors (flutter/flutter#170262)
2025-06-11 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Manually trigger `input` event in text editing tests for Safari (flutter/flutter#170022)
2025-06-11 pateltirth454@gmail.com Tiny clean-up in triage docs (flutter/flutter#170429)
2025-06-11 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#170444)
2025-06-11 flar@google.com [Impeller] Avoid creating paths when rendering arcs (flutter/flutter#170398)
2025-06-11 bruno.leroux@gmail.com Fix date picker calendar tap targets (portrait mode) (flutter/flutter#169163)
2025-06-11 fmalita@gmail.com Add SK_SUPPORT_UNSPANNED_APIS staging flag (flutter/flutter#170139)
2025-06-11 engine-flutter-autoroll@skia.org Roll Dart SDK from 6290dfd1d88a to b569246d64bc (4 revisions) (flutter/flutter#170430)
2025-06-11 engine-flutter-autoroll@skia.org Roll Skia from 910070084066 to b78fdc3ba26b (33 revisions) (flutter/flutter#170412)
2025-06-11 kjlubick@users.noreply.github.com Use pathops module groups (flutter/flutter#169857)
2025-06-10 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#170399)
2025-06-10 1961493+harryterkelsen@users.noreply.github.com Verify old version of Python has the `lib2to3` import available (flutter/flutter#170187)
2025-06-10 jason-simmons@users.noreply.github.com Use "flutter pub get" to resolve packages when building the docs snippets tool (flutter/flutter#170381)
2025-06-10 jonahwilliams@google.com [engine] Reland: ensure engines spawned from an engine using dynamic rendering selection still use the dynamic surface. (flutter/flutter#170389)
2025-06-10 jiahaog@users.noreply.github.com Revert "Add call to Dart_NotifyDestroyed when the flutter view is des… (flutter/flutter#170309)
2025-06-10 luca.randazzo@protonmail.com fix: set versionCodeOverride when split-per-abi is specified (flutter/flutter#169816)
2025-06-10 codefu@google.com fix: Skip native assets build test (flaky, takes 15m+) (flutter/flutter#170383)
2025-06-10 fluttergithubbot@gmail.com Marks Linux web_benchmarks_ddc to be unflaky (flutter/flutter#167631)
2025-06-10 fluttergithubbot@gmail.com Marks Linux web_benchmarks_ddc_hot_reload to be unflaky (flutter/flutter#168807)
2025-06-10 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[engine] ensure engines spawned from an engine using dynamic rendering selection still use the dynamic surface. (#170313)" (flutter/flutter#170377)
2025-06-10 jhy03261997@gmail.com [a11y] Semantics flag refactor step 2: embedder part (flutter/flutter#167738)
2025-06-10 engine-flutter-autoroll@skia.org Roll Dart SDK from c26e7ca44805 to 6290dfd1d88a (5 revisions) (flutter/flutter#170363)
2025-06-10 matanlurey@users.noreply.github.com Remove `pubspec.lock` files for `flutter_tools` and `widget_preview_scaffold`. (flutter/flutter#170364)
2025-06-10 jonahwilliams@google.com [engine] ensure engines spawned from an engine using dynamic rendering selection still use the dynamic surface. (flutter/flutter#170313)
...
7008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtmcdole jtmcdole jtmcdole approved these changes

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linux tool_integration_tests failing "Building flutter tool"
3 participants
@matanlurey @jtmcdole @jonahwilliams
0