_markNeedsClip() when clipper type has changed. #18248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug in _RenderCustomClip was compaeing the type of oldClipper to itself instead to the type of newClipper. This was the root cause for the crash flutter#14937 worked around. This also reverts the workaround introduced in flutter#14937.
Hixie
reviewed
Jun 6, 2018
| @@ -155,9 +155,6 @@ class _BottomAppBarClipper extends CustomClipper<Path> { | |||
|
|
|||
| @override | |||
| bool shouldReclip(CustomClipper<Path> oldClipper) { | |||
There was a problem hiding this comment.
you can make the argument type _BottomAppBarClipper here, I believe the superclass explicitly makes it covariant.
Hixie
reviewed
Jun 6, 2018
| @@ -155,9 +155,6 @@ class _BottomAppBarClipper extends CustomClipper<Path> { | |||
|
|
|||
| @override | |||
| bool shouldReclip(CustomClipper<Path> oldClipper) { | |||
| if (oldClipper.runtimeType != _BottomAppBarClipper) | |||
| return true; | |||
|
|
|||
| final _BottomAppBarClipper typedOldClipper = oldClipper; | |||
There was a problem hiding this comment.
that would also let you get rid of this line, and could indeed turn the whole method into a one-liner.
|
test? |
|
'toggle has notch' in bottom_app_bar_test is covering the bug |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug in _RenderCustomClip was compaeing the type of oldClipper to
itself instead to the type of newClipper.
This was the root cause for the crash #14937 worked around.
This also reverts the workaround introduced in #14937.