8000 Invert children for real by jonahwilliams · Pull Request #18489 · flutter/flutter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Invert children for real #18489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 15, 2018
Merged

Invert children for real #18489

merged 2 commits into from
Jun 15, 2018

Conversation

jonahwilliams
Copy link
Member

for-loops, amirite?

Fixes #18421

@jonahwilliams jonahwilliams mentioned this pull request Jun 14, 2018
Closed
@goderbauer
Copy link
Member

Can you add a test for this to ensure that they stay inverted? 😝

@jonahwilliams
Copy link
Member Author

@goderbauer this calls into Window.updateSemantics, is there a reasonable way to mock that or replace with a fake for testing? I don't see any examples of testing the actual SemanticsBuilder objects

@goderbauer
Copy link
Member

Sigh, I believe we don't have a way to mock that. :(

goderbauer
goderbauer approved these changes Jun 15, 2018
View reviewed changes
Copy link
Member
@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yjbanov
Copy link
Contributor
yjbanov commented Jun 15, 2018

lgtm

@yjbanov
Copy link
Contributor
yjbanov commented Jun 15, 2018 •
edited
Loading

Would be very cool if you could find a way to make this API testable.

@jonahwilliams jonahwilliams merged commit 1793ed7 into flutter:master Jun 15, 2018
@jonahwilliams jonahwilliams deleted the snackbar_focus branch June 15, 2018 18:22
srawlins added a commit to srawlins/flutter that referenced this pull request Jun 15, 2018
@srawlins
Merge branch 'master' into bump-mockito-beta
b0febc7 
* master:
  Remove race conditions involving finding available ports (flutter#18488)
  Skip painting hidden children of a sliver list (flutter#18465)
  Fixed some typos (flutter#18516)
  update Tristate checkbox semantics to consider indeterminate as "unchecked" (flutter#18297)
  Add flutter tool support for creating app-specific VM snapshots. (flutter#18417)
  mention Text.rich on RichText (flutter#18434)
  invert children for real (flutter#18489)
  Fix clipping for SliverLists (flutter#18410)
  Keep TextFields visible when keyboard comes up (flutter#18291)
  Update all packages (flutter#18506)
  Prepare for upgrading video player in Gallery to newest version (flutter#18501)
  Update Android dependencies (flutter#18499)
  Enable running with prebuilt test-only apk (flutter#18453)
  Revert "Update all packages (flutter#18471)" (flutter#18492)
  Add some more dart doc to RepaintBoundary (flutter#17183)
  Update all packages (flutter#18471)
  Clean up output of "flutter run --release" (flutter#18380)
  Ensure errors launching emulators are exposed to the daemon (flutter#18446)
  Check video widget is mounted on call to setState (flutter#18467)
  Fixed concurrent list modification in vmservice.dart
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yjbanov yjbanov yjbanov approved these changes

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SnackBar shown from scaffold is incorrectly ordered in semantics
4 participants
@jonahwilliams @goderbauer @yjbanov @googlebot
0