Manual engine roll with goldens #29363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaryQian
approved these changes
Mar 14, 2019
jonahwilliams
added a commit
that referenced
this pull request
Mar 14, 2019
This reverts commit c2e0891.
jonahwilliams
added a commit
that referenced
this pull request
Mar 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual engine roll needed to update goldens because of flutter/engine#8157
flutter/engine@fbca3d34e Roll src/third_party/skia 5412618d503c..f699bf0437db (2 commits) (flutter/engine#8164)
flutter/engine@23cff1a1c Roll src/third_party/skia 8b9b8f8c5846..5412618d503c (1 commits) (flutter/engine#8163)
flutter/engine@bbd58fab5 Roll src/third_party/skia 1386b2d5579d..8b9b8f8c5846 (3 commits) (flutter/engine#8162)
flutter/engine@cdf55a8d7 Roll src/third_party/skia 29d5dec9a078..1386b2d5579d (123 commits) (flutter/engine#8161)
flutter/engine@cae083657 Roll src/third_party/dart 1bd36d694d..7d560f8385 (27 commits)
flutter/engine@fcc66fc23 Suppress deprecation warning for use of Build.CPU_ABI (flutter/engine#8154)
flutter/engine@fdad56f5f Anti-Aliasing for shape layers (flutter/engine#8157)
flutter/engine@906d684a7 Reland ""Add support for trace counters with variable arguments and instrument the raster cache." (flutter/engine#8145)
flutter/engine@3c9381783 Add “full-dart-debug” that disabled optimizations in the Dart VM. (flutter/engine#8147)
flutter/engine@b1b388f1c Encode scroll motion events in the Android touch processor (flutter/engine#8149)
flutter/engine@2daebebf4 Fix text.dart height docs (flutter/engine#8079)
flutter/engine@2e427030f Revert "Disable build_ios task due to lack of credits. (flutter/engine#8150)" (flutter/engine#8153)
flutter/engine@8be2aca56 Roll src/third_party/dart 1bd36d694d..674fd0e060 (48 commits) flutter/engine#8152