-
Notifications
You must be signed in to change notification settings - Fork 28.7k
Add a flag that selects which Android device ID is the target for Flu… #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jason-simmons
merged 1 commit into
flutter:master
from
jason-simmons:android_device_id_flag
Nov 6, 2015
Merged
Add a flag that selects which Android device ID is the target for Flu… #34
jason-simmons
merged 1 commit into
flutter:master
from
jason-simmons:android_device_id_flag
Nov 6, 2015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BuildConfiguration.prebuilt({ | ||
this.hostPlatform, | ||
this.targetPlatform, | ||
this.devi 8000 ceID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deviceID -> deviceId
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
LGTM |
7d857b5
to
6e0b59f
Compare
jason-simmons
added a commit
that referenced
this pull request
Nov 6, 2015
Add a flag that selects which Android device ID is the target for Flu…
Closed
Closed
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tter commands