8000 Remove required for onRemove in InteractiveInkFeature.create by goderbauer · Pull Request #67427 · flutter/flutter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove required for onRemove in InteractiveInkFeature.create #67427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2020
Merged

Remove required for onRemove in InteractiveInkFeature.create #67427

merged 1 commit into from
Oct 6, 2020

Conversation

goderbauer
Copy link
Member
@goderbauer goderbauer commented Oct 6, 2020 •
edited
Loading

Description

I believe this was accidentally added in https://github.com/flutter/flutter/pull/67166/files#r500450922, but there is no reason for this parameter to be required. In fact, none of the subclasses mark it as required either.

Removing, since it is failing tests in google.

Related Issues

n/a

Tests

I added the following tests:

n/a

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Oct 6, 2020
goderbauer
goderbauer commented Oct 6, 2020
View reviewed changes
packages/flutter/lib/src/material/ink_well.dart
@@ -172,7 +172,7 @@ abstract class InteractiveInkFeatureFactory {
BorderRadius? borderRadius,
ShapeBorder? customBorder,
double? radius,
required VoidCallback? onRemoved,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a14n Can you confirm that there was no reason for adding the required here in the first place?

@goderbauer
Copy link
Member Author

/cc @HansMuller @Hixie @a14n @angjieli

a14n
a14n approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor
@a14n a14n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer mentioned this pull request Oct 6, 2020
Merged
13 tasks
HansMuller
HansMuller approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor
@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux web_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@goderbauer
Copy link
Member Author

Linux web_tests failed with an unrelated infra failure. Submitting to unblock google rolls.

@goderbauer goderbauer merged commit 4fa4f91 into flutter:master Oct 6, 2020
@goderbauer goderbauer deleted the fixGoogleRequired branch October 6, 2020 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a14n a14n a14n approved these changes

@HansMuller HansMuller HansMuller approved these changes

Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@goderbauer @fluttergithubbot @a14n @HansMuller @googlebot
0