Build App.framework directly to build directory #69699

jmagman · 2020-11-03T18:51:03Z

#69612 with updated ios_content_validation_test.

Description

Since #51453 we no longer need to build the App.framework to a known directory like project/ios/Flutter/App.framework. Instead, build the frameworks directly to the build products directory. For example, flutter build ios -v --simulator will build to /build/ios/Debug-iphonesimulator/App.framework.

Additionally, this sets us up to no longer need to lipo the simulator and non-simulator frameworks together since they will build to different directories.

flutter/packages/flutter_tools/lib/src/build_system/targets/ios.dart

Lines 103 to 112 in cb67513

    
           final String resultPath = environment.fileSystem.path.join(environment.buildDir.path, 'App.framework', 'App'); 
        
           environment.fileSystem.directory(resultPath).parent.createSync(recursive: true); 
        
           final ProcessResult result = await environment.processManager.run(<String>[ 
        
             'lipo', 
        
             ...darwinArchs.map((DarwinArch iosArch) => 
        
                 environment.fileSystem.path.join(buildOutputPath, getNameForDarwinArch(iosArch), 'App.framework', 'App')), 
        
             '-create', 
        
             '-output', 
        
             resultPath, 
        
           ]);

When Apple Silicon ships and ARM simulators are supported, this lipo will fail since the simulator and real device frameworks will both contain arm64.

Also stop copying the .DS_Store directories, while we're at it (already done with Flutter.framework). These files shouldn't be copied, and it adds spew during the installation phase:

[        ] [ 31%] Copying
/build/ios/iphoneos/Runner.app/Frameworks/App.framework/flutter_assets/assets/navbar/.DS_Store to
device

Related Issues

#60118

Tests

Updated ios_content_validation_test. Already many many integration tests that will blow up in the compiled dart code or flutter_assets are missing.

jmagman · 2020-11-03T18:52:08Z

dev/devicelab/bin/tasks/ios_content_validation_test.dart

+            'BUILT_PRODUCTS_DIR': path.join(
+              flutterProject.rootPath,
+              'build',
+              'ios',
+              'Release-iphoneos',
+            ),


This has been added to #69612.

This test fakes out some Xcode build settings to directly test xcode_backend. We can always rely on BUILT_PRODUCTS_DIR being present when run directly in Xcode.

jonahwilliams

LGTM!

jmagman added 3 commits November 3, 2020 10:33

Build App.framework directly to build directory

dc36cfb

Update migration instructions

5be2768

Update ios_content_validation_test

cf64f3f

jmagman added the t: xcode "xcodebuild" on iOS and general Xcode project management label Nov 3, 2020

jmagman requested a review from jonahwilliams November 3, 2020 18:51

jmagman self-assigned this Nov 3, 2020

flutter-dashboard bot added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels Nov 3, 2020

google-cla bot added the cla: yes label Nov 3, 2020

jmagman commented Nov 3, 2020

View reviewed changes

jonahwilliams approved these changes Nov 3, 2020

View reviewed changes

jmagman merged commit 91b8234 into flutter:master Nov 3, 2020

jmagman deleted the app-fw-build-loc branch November 3, 2020 20:48

jmagman mentioned this pull request Dec 15, 2020

Build/copy macOS frameworks to built products instead of ephemeral directory #72378

Merged

jmagman added the platform-host-arm Building on an ARM-based platform label Aug 20, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build App.framework directly to build directory #69699

Build App.framework directly to build directory #69699

	final String resultPath = environment.fileSystem.path.join(environment.buildDir.path, 'App.framework', 'App');
	environment.fileSystem.directory(resultPath).parent.createSync(recursive: true);
	final ProcessResult result = await environment.processManager.run(<String>[
	'lipo',
	...darwinArchs.map((DarwinArch iosArch) =>
	environment.fileSystem.path.join(buildOutputPath, getNameForDarwinArch(iosArch), 'App.framework', 'App')),
	'-create',
	'-output',
	resultPath,
	]);

Build App.framework directly to build directory #69699

Build App.framework directly to build directory #69699

Conversation

Description

Related Issues

Tests

Choose a reason for hiding this comment

Choose a reason for hiding this comment