8000 [flutter_releases] Flutter 1.26.0-17.1.pre Dev - Revert vm_service, other packages from pub roll by christopherfujino · Pull Request #74937 · flutter/flutter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[flutter_releases] Flutter 1.26.0-17.1.pre Dev - Revert vm_service, other packages from pub roll #74937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2021
Merged

[flutter_releases] Flutter 1.26.0-17.1.pre Dev - Revert vm_service, other packages from pub roll #74937

merged 1 commit into from
Jan 29, 2021

Conversation

christopherfujino
Copy link
Contributor

This reverts d153832 to avoid dart-lang/sdk#44800 in package vm_service.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Jan 28, 2021
@google-cla
Copy link
google-cla bot commented Jan 28, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jan 28, 2021
@christopherfujino christopherfujino changed the base branch from master to flutter-1.26-candidate.17 January 28, 2021 22:12
@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

dnfield
dnfield approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor
@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnfield
Copy link
Contributor
dnfield commented Jan 28, 2021

Not sure why googlebot is upset, but I've signed a CLA and this reverts my commit and I'm ok with all of that.

@christopherfujino
Copy link
Contributor Author
christopherfujino commented Jan 28, 2021 •
edited
Loading

Not sure why googlebot is upset, but I've signed a CLA and this reverts my commit and I'm ok with all of that.

Yeah, Googlebot doesn't know how to handle commits with multiple authors, even if all authors have signed the CLA.

@pcsosinski
Copy link

title should 17.1.pre?

@christopherfujino
Copy link
Contributor Author

title should 17.1.pre?

Good catch.

@christopherfujino christopherfujino changed the title [flutter_releases] Flutter 1.26.0-17.0.pre Dev - Revert vm_service, other packages from pub roll [flutter_releases] Flutter 1.26.0-17.1.pre Dev - Revert vm_service, other packages from pub roll Jan 28, 2021
@google-cla google-cla bot removed the cla: no label Jan 28, 2021
@christopherfujino
Copy link
Contributor Author

Manually overrided clabot as all authors are Googlers.

@christopherfujino christopherfujino merged commit c40e529 into flutter:flutter-1.26-candidate.17 Jan 29, 2021
@christopherfujino christopherfujino deleted the cherrypicks-flutter-1.26-candidate.17 branch February 10, 2021 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnfield dnfield dnfield approved these changes

@pcsosinski pcsosinski pcsosinski approved these changes

Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christopherfujino @dnfield @pcsosinski
0