8000 Revert "Roll Plugins from a9513d592101 to 1c0090511fc8 (3 revisions)" by jmagman · Pull Request #73056 · flutter/flutter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Revert "Roll Plugins from a9513d592101 to 1c0090511fc8 (3 revisions)" #73056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2020
Merged

Revert "Roll Plugins from a9513d592101 to 1c0090511fc8 (3 revisions)" #73056

merged 1 commit into from
Dec 28, 2020

Conversation

jmagman
Copy link
Member
@jmagman jmagman commented Dec 28, 2020

Reverts #73049

This is causing a post-commit failure:

Checking project camera...

  error - 5 positional argument(s) expected, but 3 found at test/camera_test.dart:29:59 - (not_enough_positional_arguments)
  error - 'MockCameraPlatform.startVideoRecording' ('Future<XFile> Function(int)') isn't a valid override of 'CameraPlatform.startVideoRecording' ('Future<void> Function(int, {Duration maxVideoDuration})') at test/camera_test.dart:644:17 - (invalid_override)

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8859638456219088016/+/steps/run_test.dart_for_flutter_plugins_shard_and_subshard_analyze/0/stdout

@google-cla google-cla bot added the cla: yes label Dec 28, 2020
@jmagman
Copy link
Member Author
jmagman commented Dec 28, 2020

Merging to green tree.

@jmagman jmagman merged commit b009cfd into master Dec 28, 2020
@jmagman jmagman deleted the revert-73049-flutter-plugins-flutter-autoroll-ef0254f3-65e2-400b-ba3c-aecf8f53b7b1-1609182228 branch December 28, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jmagman
0