Exclude arm64 from valid iOS simulators #73828
Conversation
25831f6 to
88b903e
Compare
| 'objc', | ||
| 'hello', | ||
| ], workingDirectory: tempDir.path); | ||
| group('iOS app validation', () { |
There was a problem hiding this comment.
Most of this file is whitespace changes.
| timeout: const Timeout(Duration(minutes: 5)), | ||
| ); | ||
| } | ||
| testWithoutContext('build for simulator with all available architectures', () { |
|
Third time's the charm (maybe)! |
|
Can you remind me what the failure was last time? Xcode version issues? |
Xcode 11 had an allow list s.pod_target_xcconfig = { 'DEFINES_MODULE' => 'YES', 'VALID_ARCHS[sdk=iphonesimulator*]' => 'x86_64' }Xcode 12 has a new When both were present, Xcode 11 had a little freak out, which was the cause for the last two reverts (this took me hours to figure out). That error doesn't even make sense--the But now the devicelab is on Xcode 12 and it's the minimum version the tool allows for developers. Xcode 12 handles these build settings, so with this PR even when plugins have |
Another attempt at #73458 on top of minimum Xcode 12 version bump.
Description
Exclude unsupported new arm64 and old i386 iOS simulators at the build setting layer. This will allow the excluded architectures to be excluded when the project is run from Xcode, instead of just from the
fluttercommand line.Do this for plugin targets (in the podhelper) as well as in the Runner app target (Generated.xcconfig).
Update the add-to-app host apps to exclude arm64 simulators since Flutter still doesn't contain that slice.
Sample code update: flutter/samples#646
Website docs update: flutter/website#5174
#64502 (comment)
Added a ios_content_validation_test case to target the simulator with
ONLY_ACTIVE_ARCH=NOwhich will target all valid architectures that have not been explicitly excluded. This test case would fail if arm64 or i386 were not excluded.