Correct values for semi-transparent hex colors #8153
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hex colors are typically encoded with the sRGB transfer function. In this case, the values specified here translate directly to SkColors (which are defined by Skia to be sRGB). Therefore, the value corresponding to N% of a color is actually 255 * LinearToSRGB(N / 100). This CL corrects that logical error. In the short term, this will make blacks appear darker and whites appear lighter. Once color correct Skia is enabled, the colors will look similar to how they appear now (though this is dependent on the background).
|
Oops, this doesn't make any sense. Please disregard. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hex colors are typically encoded with the sRGB transfer function.
In this case, the values specified here translate directly to
SkColors (which are defined by Skia to be sRGB).
Therefore, the value corresponding to N% of a color is actually
255 * LinearToSRGB(N / 100).
This CL corrects that logical error.
In the short term, this will make blacks appear darker and whites
appear lighter. Once color correct Skia is enabled, the colors
will look similar to how they appear now (though this is
dependent on the background).
#8152