This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[webview_flutter_android] Adds the scroll position method to WebView and updates pigeon instructions #6366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
approved these changes
Sep 12, 2022
| @@ -141,6 +141,8 @@ abstract class WebViewHostApi { | |||
|
|
|||
| int getScrollY(int instanceId); | |||
|
|
|||
| List<int> getScrollPosition(int instanceId); | |||
There was a problem hiding this comment.
Let's make a WebViewPoint class in the Pigeon definition, and return that, so it's self-documenting what the values mean, and we don't have to worry about things like a length mismatch. (It's less efficient over the wire for now, but it's not a big deal, and it's also something we plan to fix in future versions of Pigeon anyway.)
We could consider using it for scrollTo as well.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 14, 2022
…o WebView and updates pigeon instructions (flutter/plugins#6366)
adam-harwood
pushed a commit
to adam-harwood/flutter_plugins
that referenced
this pull request
Nov 3, 2022
…and updates pigeon instructions (flutter#6366)
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
…and updates pigeon instructions (flutter#6366)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a scroll position method for
WebViewthat will be used in the v4WebViewController.getScrollPosition()interface method.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.