fix: update base image to 1.8.1, enhance error message in InputImage,… #569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and add AVIF test cases
There was a problem hiding this comment.
Pull Request Overview
This PR updates the base Docker image to 1.8.1, improves the exception message in InputImage, and adds AVIF test coverage for face cropping.
- Bump base image from
1.7.1to1.8.1. - Enhance
ReadFileExceptionto include the missing file path. - Add AVIF output test in
FaceDetectProcessorTestand corresponding constant inBaseTest.
Reviewed Changes
Copilot reviewed 4 out of 8 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Dockerfile | Updated flyimg/base-image tag to 1.8.1. |
| src/Core/Entity/Image/InputImage.php | Enhanced ReadFileException message to include sourceImageUrl. |
| tests/Core/BaseTest.php | Added FACES_CP0_TEST_IMAGE_AVIF constant for AVIF reference. |
| tests/Core/Processor/FaceDetectProcessorTest.php | Added AVIF output test and file existence/size assertions. |
Comments suppressed due to low confidence (3)
tests/Core/Processor/FaceDetectProcessorTest.php:23
- [nitpick] The variable
$filesize2is ambiguous. Consider renaming it to something like$expectedFilesizefor clarity.
$this->assertEquals($filesize, $filesize2);
src/Core/Entity/Image/InputImage.php:189
- Consider adding a unit test to cover the new exception message when a local file path does not exist, ensuring it includes the missing path.
throw new ReadFileException('Local file ' . $this->sourceImageUrl . ' does not exist.');
tests/Core/Processor/FaceDetectProcessorTest.php:26
- [nitpick] The docblock indentation is inconsistent with the rest of the file. Align it to 4 spaces to match the method definitions.
/**
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ception constructor for better flexibility; enhance tests for exception handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: update base image to 1.8.1, enhance error message in InputImage and add AVIF test cases