8000 Run unit tests in CI and use go 1.22 by eapolinario · Pull Request #18 · flyteorg/stow · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Run unit tests in CI and use go 1.22 #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Run unit tests in CI and use go 1.22 #18

wants to merge 4 commits into from

Conversation

eapolinario
Copy link
@eapolinario eapolinario commented Dec 17, 2024 •
edited
Loading

We have a few unit tests, so let's make that those run in CI on PRs and merges to master.

edit: I also bumped the version to match the one in the main flyte repo since unit tests were failing to run in CI due to:

go: downloading golang.org/x/text v0.16.0
Error: ../../../go/pkg/mod/golang.org/x/crypto@v0.25.0/curve25519/curve25519.go:13:8: package crypto/ecdh is not in GOROOT (/opt/hostedtoolcache/go/1.18.10/x64/src/crypto/ecdh)
Error: Process completed with exit code 1.

@eapolinario
Run unit tests in a github workflow
f96b0f6 
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@eapolinario
Bump go version to 1.22
ef9bcb8 
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@eapolinario
Remove name and other properties from gh workflow
3102dee 
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@eapolinario eapolinario changed the title Run unit tests in CI Run unit tests in CI and use go 1.22 Dec 17, 2024
@eapolinario eapolinario mentioned this pull request Dec 17, 2024
Merged
@ddl-ebrown
Copy link

@eapolinario wondering if you're going to get this one updated for Go 1.23?

I see the effort has started over at flyteorg/flyte#6249 for Flyte ... haven't looked closely enough at Stow or its dependencies to see if there are any Go 1.23 concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eapolinario @ddl-ebrown
0