8000 Use python to parse configs by hkethi002 · Pull Request #8 · flywheel-apps/curate-bids · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Jun 24, 2021. It is now read-only.

Use python to parse configs #8

Merged
merged 2 commits into from
Jun 25, 2018
Merged

Use python to parse configs #8

merged 2 commits into from
Jun 25, 2018

Conversation

hkethi002
Copy link
Contributor

No description provided.

@hkethi002 hkethi002 requested a review from ehlertjd June 25, 2018 17:13
Copy link
Collaborator
@ehlertjd ehlertjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after minor variable name changes.

run.py Outdated
if __name__ == '__main__':

# Grab Config
config = '/flywheel/v0/config.json'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor style comment: Use CAPS for constants (i.e. CONFIG_FILE_PATH) and lowercase for local variables (i.e. the loaded configuration)

@hkethi002 hkethi002 merged commit 45bc544 into master Jun 25, 2018
@hkethi002 hkethi002 deleted the python-run branch June 25, 2018 17:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0