8000 Add config option to run on session only by ehlertjd · Pull Request #11 · flywheel-apps/curate-bids · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Jun 24, 2021. It is now read-only.

Add config option to run on session only #11

Merged
merged 1 commit into from
Jul 19, 2018
Merged

Add config option to run on session only #11

merged 1 commit into from
Jul 19, 2018

Conversation

ehlertjd
Copy link
Collaborator

No description provided.

@ehlertjd ehlertjd requested a review from hkethi002 July 19, 2018 18:48
Copy link
Contributor
@hkethi002 hkethi002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

"entire_project": {
"description": "Run bids curation on the entire project",
"type": "boolean",
"default": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this is set to true so that it won't confuse current users?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, seemed slightly clearer to name the property this way and make it the default.

@ehlertjd ehlertjd merged commit 2b0f9b0 into master Jul 19, 2018
@ehlertjd ehlertjd deleted the session-only branch July 19, 2018 21:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0