8000 fix: coerce NodeList to an array before iterating by aearly · Pull Request #2 · fnando/sparkline · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: coerce NodeList to an array before iterating #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms 8000 of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2018
Merged

fix: coerce NodeList to an array before iterating #2

merged 1 commit into from
Mar 9, 2018

Conversation

aearly
Copy link
Contributor
@aearly aearly commented Feb 22, 2018

NodeLists only recently grew a forEach method. This copies the result of querySelectorAll into a new array so we can use forEach with it in a wider set of browsers.

@aearly
Copy link
Contributor Author
aearly commented Mar 6, 2018

For reference, we're going to be using this on the next version of the npm website: https://preview.npmjs.com/package/jest

@fnando fnando merged commit e7f6751 into fnando:master Mar 9, 2018
@fnando
Copy link
Owner
fnando commented Mar 9, 2018

Thanks, @aearly! The new NPM looks neat! 😍

@fnando
Copy link
Owner
fnando commented Mar 9, 2018

BTW, just released v0.3.5 with this fix.

@akshithrk akshithrk mentioned this pull request Mar 23, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aearly @fnando
0