8000 Update README.md by jaime-olivares · Pull Request #1995 · fo-dicom/fo-dicom · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update README.md #1995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2025
Merged

Update README.md #1995

merged 2 commits into from
Jul 10, 2025
+11 −15

Conversation

jaime-olivares
Copy link
Contributor

Very little spell/grammar check and adjusted a couple of tables for better fit.

Checklist

  • The pull request branch is in sync with latest commit on the fo-dicom/development branch
  • I have updated API documentation
  • I have included unit tests
  • I have updated the change log
  • I am listed in the CONTRIBUTORS file

Changes proposed in this pull request:

README.md

@jaime-olivares
Update README.md
0639d6b 
Very little spell/grammar check and adjusted a couple of tables for better fit.
@codecov Codecov
Copy link
codecov bot commented Jul 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.90%. Comparing base (8605153) to head (5029128).
Report is 1 commits behind head on development.

Additional details and impacted files 
@@             Coverage Diff              @@
##           development    #1995   +/-   ##
============================================
  Coverage        76.90%   76.90%           
============================================
  Files              276      276           
  Lines            25722    25722           
  Branches          3053     3053           
============================================
  Hits             19782    19782           
  Misses            5013     5013           
  Partials           927      927

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mrbean-bremen
mrbean-bremen reviewed Jul 9, 2025
View reviewed changes
Copy link
Collaborator
@mrbean-bremen mrbean-bremen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While at it, you could also remove "(and only on Windows)" in the "Supported Runtimes" chapter, as it is no longer true (I missed this at the time).
Also, in the "Installation" part: "This package reference the core fo-dicom assemblies" should read "references".
And "Cross-platform Dicom codecs" (fo-ddicom.Codecs description) should use "DICOM".

@jaime-olivares
Copy link
Contributor Author

While at it, you could also remove "(and only on Windows)" in the "Supported Runtimes" chapter, as it is no longer true (I missed this at the time). Also, in the "Installation" part: "This package reference the core fo-dicom assemblies" should read "references". And "Cross-platform Dicom codecs" (fo-ddicom.Codecs description) should use "DICOM".

done

@jaime-olivares
Copy link
Contributor Author

I see the changes in README is triggering a full build and codecov analysis. This is usually skipped in the build script.

mrbean-bremen
mrbean-bremen approved these changes Jul 9, 2025
View reviewed changes
Copy link
Collaborator
@mrbean-bremen mrbean-bremen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mrbean-bremen
Copy link
Collaborator
mrbean-bremen commented Jul 9, 2025 •
edited
Loading

This is usually skipped in the build script

There is no check currently for this, the full build is triggered on each commit in a PR (usually all changes are code changes, so this probably never came up).

@gofal
Copy link
Contributor
gofal commented Jul 10, 2025

Great, thanks!

@mrbean-bremen mrbean-bremen merged commit bccf88d into fo-dicom:development Jul 10, 2025
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrbean-bremen mrbean-bremen mrbean-bremen approved these changes

@gofal gofal gofal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaime-olivares @mrbean-bremen @gofal
0