8000 Clarify user expectations for getStatNames by madig · Pull Request #2892 · fonttools/fonttools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Clarify user expectations for getStatNames #2892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 16, 2025
Merged

Clarify user expectations for getStatNames #2892

merged 2 commits into from
Apr 16, 2025

Conversation

madig
Copy link
Collaborator
@madig madig commented Nov 16, 2022

Closes #2890

anthrotype
anthrotype approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member
@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, though maybe we could also mention something along the same lines in the designspace xml docs, in addition to these inlined docstrings?

@belluzj
Copy link
Contributor
belluzj commented Nov 18, 2022

In the XML docs we should mention the name attributes on instances are no longer mandatory if you have STAT info in the file

@madig madig requested a review from anthrotype November 22, 2022 16:26
@khaledhosny khaledhosny merged commit 01312bb into main Apr 16, 2025
@khaledhosny khaledhosny deleted the dslib-stat-instances-clarify branch April 16, 2025 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthrotype anthrotype Awaiting requested review from anthrotype

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@madig @belluzj @anthrotype @khaledhosny
0